Conversation
pezholio
force-pushed
the
update-developer-docs
branch
from
928df6e to
71bdeb7
Compare
We’ve now added JS dependencies (see alphagov/govuk-developer-docs#5019) so we should add `yarn` as a step when making and spinning up the project.
As outlined in alphagov/govuk-developer-docs@4b624a7 this is a recommended setting when running the app. I also had problems running the app without it.
pezholio
force-pushed
the
update-developer-docs
branch
from
71bdeb7 to
eaa8429
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
yarnstep to Developer Docs now we have JS dependencies (see alphagov/govuk-developer-docs#5019), as well as adding aNO_CONTRACTSenv var to skip some of Middleman's magic typechecking, which slows the build down.