Conversation
The terraform that generates our edge-rate limiting is the only thing that generates 829 errors in our VCL. The terraform also generates code that handles the errors. It's in the "complete VCL" in the Fastly console, and looks a bit like this:
```
"# Snippet rate-limiter-v1-someid-error-error : 100
"# Begin rate-limiter rate_limiter error
if (obj.status == 829 && obj.response == "Rate limiter: Too many requests for someid") {
set obj.status = 429;
set obj.response = "Too Many Requests";
set obj.http.Content-Type = "plain/text";
synthetic.base64 "VG9vIG1hbnkgcmVxdWVzdHM=";
return(deliver);
}
```
There are two of these sections at the moment, in addition to the section I'm removing here.
It's notable that we set a `Fastly-Backend-Name` that, I think should appear in the origins inspector along with the S3 buckets, but doesn't. I'm taking this as being further evidence that this isn't a code path that's executed.
If we wanted to examine this further, we could possibly instrument this section in some way, or use a "beacon" in the markup that we send back.
samsimpson1
approved these changes
Sep 23, 2025
Contributor
|
Converting to Draft until it's ready to be merged so it's not flagged by the Seal. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terraform that generates our edge-rate limiting is the only thing that generates 829 errors in our VCL. The terraform also generates code that handles the errors. It's in the "complete VCL" in the Fastly console, and looks a bit like this:
First terraform-generated section
Second terraform-generated section
Our code that I'd like to remove
It's notable that we set a
Fastly-Backend-Namethat, I think should appear in the origins inspector along with the S3 buckets, but doesn't. I'm taking this as being further evidence that this isn't a code path that's executed.If we wanted to examine this further, we could possibly instrument this section in some way, or use a "beacon" in the markup that we send back.