Open
Conversation
quis
changed the title
quis
force-pushed
the
validate-email-file-not-in-subject
branch
from
ab8df9d to
0843e68
Compare
quis
force-pushed
the
validate-email-file-not-in-subject
branch
from
0843e68 to
c8617d1
Compare
rparke
reviewed
Mar 17, 2026
rparke
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment someone could take a file placeholder and copy it into the subject of the email. This will sort of work if they have no link text, but will look broken if they specify link text.
Because we don’t think there’s a valid use case for this behaviour let’s add some validation to stop it happening. This means it’s not behaviour that we have to support in perpetuity.
When editing a template
When uploading a file