Draft
Conversation
risicle
force-pushed
the
ris-celery-mgid-headers
branch
from
65e36e4 to
5e678bb
Compare
risicle
force-pushed
the
ris-celery-mgid-headers
branch
from
5e678bb to
c6dd35f
Compare
Contributor
|
I like this approach, I think we knew some information for grouping wouldn't be available everywhere but I think this approach is clean and makes the most of it We can always revert back to just service_id if better but I think it's a good start |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required utils branch is at alphagov/notifications-utils#1296
This has to do
getattr(self, "message_group_id", None)for now becuase of the weird way we create ourNotifyTaskclass - I know how to fix this though.