Skip to content

Add provider selection option and persist requested provider#4712

Draft
corlettb wants to merge 1 commit intomainfrom
BC-provider-option
Draft

Add provider selection option and persist requested provider#4712
corlettb wants to merge 1 commit intomainfrom
BC-provider-option

Conversation

@corlettb
Copy link
Contributor

Trello

Notes

  • Still pending tests in an environment

What

  • Add provider_requested to notifications/jobs/history and all-time view
  • Accept provider in v2 payloads and CSV job metadata with validation/gating
  • Persist requested provider while keeping sent_by as actual provider
  • Route SMS/email via requested provider when valid; fail closed if unavailable
  • Support SMS/email stubs and letter stub selection (dvla-stub)
  • Add helper for provider validation/allowed set
  • Update schemas, job API, and Celery payloads
  • Add migration + update current alembic head
  • Expand tests for provider option, job encoding, and schemas

Notes:

  • Provider option gated by PROVIDER_OPTION_ENABLED; invalid provider returns 400
  • Letter stub selection also gated by LETTER_STUB_ENABLED
  • Existing routing unchanged when provider is omitted

Summary:
- Add provider_requested to notifications/jobs/history and all-time view
- Accept provider in v2 payloads and CSV job metadata with validation/gating
- Persist requested provider while keeping sent_by as actual provider
- Route SMS/email via requested provider when valid; fail closed if unavailable
- Support SMS/email stubs and letter stub selection (dvla-stub)
- Add helper for provider validation/allowed set
- Update schemas, job API, and Celery payloads
- Add migration + update current alembic head
- Expand tests for provider option, job encoding, and schemas

Notes:
- Provider option gated by PROVIDER_OPTION_ENABLED; invalid provider returns 400
- Letter stub selection also gated by LETTER_STUB_ENABLED
- Existing routing unchanged when provider is omitted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant