Open
Conversation
Newer (2.11.0 and onwards) versions of PyJWT won’t let us created a token with a non-string ISS field. To ensure we still handle the case where we decode such a token, this adds an extra test that uses mocking to raise the same exception that PyJWT would.
We can get this as a sub-dependencies so it doesn’t need to be in our `requirements.in` file. The admin app is already running this version: - https://github.com/alphagov/notifications-admin/blob/c37a07307ecbc0491c71cfd52f48ed08a88ea07e/requirements.txt#L129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can get this as a sub-dependency so it doesn’t need to be in our
requirements.infile.The admin app is already running this version: