process_sms_client_response: accept & log delivery_iso_timestamp & receipt_iso_timestamp#4783
Open
process_sms_client_response: accept & log delivery_iso_timestamp & receipt_iso_timestamp#4783
process_sms_client_response: accept & log delivery_iso_timestamp & receipt_iso_timestamp#4783Conversation
…ceipt_iso_timestamp args optional with a default of None, these timestamps can be provided by the endpoint responsible for putting the task on the queue. at some point we may want to do something better with these, e.g. produce a metric or save the information to the database, but for now this is better than nothing and the log message will give us a bit of a paper trail for individual notifications. deliberately feeding the timestamps through the queue rather than doing something with them in the callback handler because the callback handler doesn't currently do any explicit logging of its own and we don't want to add a new log message on the account of this - it's yet to be seen how reliable or useful the "delivery time" reported by sms providers even is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional with a default of
None, these timestamps can be provided by the endpoint responsible for putting the task on the queue.At some point we may want to do something better with these, e.g. produce a metric or save the information to the database, but for now this is better than nothing and the log message will give us a bit of a paper trail for individual notifications.
Deliberately feeding the timestamps through the queue rather than doing something with them in the callback handler because the callback handler doesn't currently do any explicit logging of its own and we don't want to add a new log message on the account of this - it's yet to be seen how reliable or useful the "delivery time" reported by sms providers even is.
--
This is the first PR of 2, the second of which will actually start providing the arguments in the callback handler. This PR has to be merged & released first though to ensure a smooth rollout.