Closed
Conversation
BlessedDev
force-pushed
the
add_0546_update_permissions_type_enum
branch
from
9681f92 to
7f0bf52
Compare
Member
|
Why do we need special timeout values for this particular migration? Also note I think you're setting these values session-wide, so migrations that run after this one will presumably inherit these settings. |
Contributor
Author
I had added it to get past a lint-migration error message, that recommended those statements and settings . I will try to see if I can get it to pass the test if I remove it. |
This adds send_files_via_ui to the permissions_type enum
BlessedDev
force-pushed
the
add_0546_update_permissions_type_enum
branch
from
7f0bf52 to
3a067b8
Compare
Contributor
Author
|
This isn't needed. The service permission was erroneously being added to user permissions in the proposed Functional. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds send_files_via_ui to the permissions_type enum