Open
Conversation
whpearson
force-pushed
the
stop_retry_failed_notification
branch
from
a785241 to
e40f4ed
Compare
…er exceptions Job Id and job row number are unique in the notifications table so they can be used to see if a notification has been added to the db already even if the notification has been given a different notification id. Handle error is the logic for all types of notification, but I only tested one save function .
whpearson
force-pushed
the
stop_retry_failed_notification
branch
from
e40f4ed to
ce85461
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding get_notifcation_by_job_and_job_row_number and using it to filter exceptions
Job Id and job row number are unique in the notifications table so they can be used
to see if a notification has been added to the db already even if the notification
has been given a different notification id.
Handle error is the logic for all types of notification, but I only tested one save function