[PP-14099]: Handle transforming ADOT logs#49
Merged
Conversation
kbottla
approved these changes
May 29, 2025
| return extractAppLogTime(log) | ||
| case CloudWatchLogTypes.adot: | ||
| // Adot has many different time formats, so we'll rely on the cloudwatch timestamp instead | ||
| return undefined |
Contributor
There was a problem hiding this comment.
We might want to remove console.log('Using cloudwatch event time') on line 129, as it will be logged for every adot log line.
Contributor
Author
There was a problem hiding this comment.
As it happens though, with ADOT when you have the log level as WARN it basically only logs on startup and shutdown (unless things are going wrong I guess).
But I think you're still right, it might be good to gate the logs behind a debug flag like with the current lambdas, and the s3 to firehose one.
I'll do that as a follow on
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle transforming the adot logs
Unfortunately ADOT logs in lots of formats, so lets not deal with any of it, instead lets just ship them as a generic log line, and set the timestamp (of which there are several formats, and many lines without a format) to the timestamp the log lines get in cloudwatch.