Store old index for breach before reindexing

[alphaleadership]

Assign old index to breach before updating the index.

---

Summary by cubic

Store the previous index on each breach as oldindex before reindexing so we can track changes and update references after resorting. This prevents losing the original index when retired breaches are skipped.

^{Written for commit aca675f. Summary will update on new commits.}

[gemini-code-assist]

Summary of Changes

Hello @alphaleadership, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the breach reindexing script to ensure that the original index of each breach is preserved. By introducing an oldindex property, the system can now retain the previous indexing state before assigning a new index, which could be valuable for auditing, debugging, or potential rollback scenarios.

Highlights

• Preservation of Original Index: The pull request introduces a mechanism to store the original index value of each breach object into a new oldindex property before the index is updated during the reindexing process.
• Script Modification: A single line of code has been added to the scripts/resort-breaches.js file to implement this change, ensuring the oldindex is captured prior to the index reassignment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements the logic to store the old index of a breach before re-indexing. My review includes a minor suggestion to improve code style for better readability and consistency with JavaScript best practices.

[gemini-code-assist]

For better readability and to avoid potential issues with Automatic Semicolon Insertion (ASI), it's good practice to add spaces around operators and end statements with a semicolon.

Regarding the property name, you might consider using camelCase (oldIndex) to align with common JavaScript conventions, though I see the existing index property is lowercase, so oldindex maintains local consistency.

Suggested change

	breach.oldindex=breach.index
	breach.oldindex = breach.index;

[cubic-dev-ai]

1 issue found across 1 file

Confidence score: 5/5

• Minor style nits in scripts/resort-breaches.js (camelCase and spacing) are low-risk and don’t affect runtime behavior.
• Pay close attention to scripts/resort-breaches.js - align oldIndex casing and spacing for consistency.

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="scripts/resort-breaches.js">

<violation number="1" location="scripts/resort-breaches.js:75">
P3: Property name `oldindex` should use camelCase (`oldIndex`) for consistency with other properties like `isNSFW`. Also, add spaces around `=` to match the style of the adjacent line `breach.index = i;`.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P3: Property name oldindex should use camelCase (oldIndex) for consistency with other properties like isNSFW. Also, add spaces around = to match the style of the adjacent line breach.index = i;.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At scripts/resort-breaches.js, line 75:

<comment>Property name `oldindex` should use camelCase (`oldIndex`) for consistency with other properties like `isNSFW`. Also, add spaces around `=` to match the style of the adjacent line `breach.index = i;`.</comment>

<file context>
@@ -72,6 +72,7 @@ db.breaches.forEach((breach, idx) => {
   if(!breach.IsRetired){
     i++
   }
+  breach.oldindex=breach.index
   breach.index = i;
 })
</file context>

Suggested change

	breach.oldindex=breach.index
	breach.oldIndex = breach.index