Fix missing newline between TODOs and next section when ungrouped#209
Open
kovan wants to merge 1 commit intoalphapapa:masterfrom
Open
Fix missing newline between TODOs and next section when ungrouped#209kovan wants to merge 1 commit intoalphapapa:masterfrom
kovan wants to merge 1 commit intoalphapapa:masterfrom
Conversation
When TODOs are displayed without grouping, the depth argument was incorrectly incremented before being passed to magit-todos--insert-group, causing the section to not be treated as top-level. This also meant no trailing blank line was inserted after the section body, breaking the visual separator between it and the next magit section. Fix by passing depth as-is (instead of (1+ depth)) and adding a trailing newline in magit-todos--insert-group for top-level sections, matching the existing behavior in the grouped code path. Fix: alphapapa#202 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202 — no blank line between ungrouped TODOs section and next magit section.
Two issues in the ungrouped code path:
(1+ depth)passed instead ofdepth→ section parented incorrectly (not at root)\nat depth 0, unlike the grouped pathFix: pass
depthdirectly and add(when (= 0 depth) (insert "\n"))after thedolist.Verified on Emacs 30.2: reproduced missing newline with
magit-todos-group-bynil, applied fix, confirmed\n\nat section boundary.