Conversation
|
Hi, Thanks, this looks like a useful feature. I'll post a few comments as a review. |
|
B.t.w, it is not easy for human eyes to follow the line when performing |
alphapapa
left a comment
There was a problem hiding this comment.
B.t.w, it is not easy for human eyes to follow the line when performing magit-todos-peek-at-item, especially when navigating todos fast using magit-todos-next-todo. It seems better to highlight the peeked line, or use a overlay, or just center the popped buffer.
This may depend on your personal Emacs configuration. As far as I know, peeking at the item should display it in the "peeking" window.
It could be helpful to display a highlight or overlay, but I'd prefer to avoid adding code to that effect unless it's really necessary. Users can use advice to do that if they want.
README.org
Outdated
| @@html:<kbd>@@p@@html:</kbd>@@, @@html:<kbd>@@C-p@@html:</kbd>@@, | ||
| @@html:<kbd>@@<up>@@html:</kbd>@@ to follow the file of the previous todo item. | ||
| Activate =magit-todos-follow-mode= in the to-do buffer, use: | ||
| + @@html:<kbd>@@n@@html:</kbd>@@ :: Follow the next todo item and display the corresponding file |
There was a problem hiding this comment.
Please use this text, like the previous list:
Peek at the (next|previous) item.
There was a problem hiding this comment.
If you want the command list looks consistent, it maybe better to use
Peek at the next item when =magit-todos-follow-mode= is activated.
Peek at the previous item when =magit-todos-follow-mode= is activated.
What do you think? You can always edit my branch if you want. :)
|
Note that I just pushed some new code to master, so please rebase it. |
7648995 to
8f634a2
Compare
9f5a88e to
8a6ac01
Compare
|
@maxc01 Looking at this again, and having learned how well the |
|
Hi @alphapapa , sorry for the late reply. Current I am using rg.el and have defined a todo search in the current project. It supports follow mode out-of-the-box. It lacks the fancy interface provided by your package, but it works for me fairly well. |
When in magit-todos-mode, we can use
n, C-n, or <down>to directly navigate to the associated file of the next todo item and usep, C-p, or <up>to directly navigate to the associated file of the previous todo item.