Skip to content

use explicit import everywhere #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimmywarting wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use explicit import everywhere #4589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/alpinejs/builds/cdn.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Alpine from './../src/index'
import Alpine from '../src/index.js'

window.Alpine = Alpine

Expand Down
2 changes: 1 addition & 1 deletion packages/alpinejs/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Alpine from './../src/index'
import Alpine from '../src/index.js'

export default Alpine

Expand Down
42 changes: 21 additions & 21 deletions packages/alpinejs/src/alpine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
import { setReactivityEngine, disableEffectScheduling, reactive, effect, release, raw, watch } from './reactivity'
import { mapAttributes, directive, setPrefix as prefix, prefix as prefixed } from './directives'
import { start, addRootSelector, addInitSelector, closestRoot, findClosest, initTree, destroyTree, interceptInit } from './lifecycle'
import { onElRemoved, onAttributeRemoved, onAttributesAdded, mutateDom, deferMutations, flushAndStopDeferringMutations, startObservingMutations, stopObservingMutations } from './mutation'
import { mergeProxies, closestDataStack, addScopeToNode, scope as $data } from './scope'
import { setEvaluator, evaluate, evaluateLater, dontAutoEvaluateFunctions } from './evaluator'
import { transition } from './directives/x-transition'
import { clone, cloneNode, skipDuringClone, onlyDuringClone, interceptClone } from './clone'
import { interceptor } from './interceptor'
import { getBinding as bound, extractProp } from './utils/bind'
import { debounce } from './utils/debounce'
import { throttle } from './utils/throttle'
import { setStyles } from './utils/styles'
import { entangle } from './entangle'
import { nextTick } from './nextTick'
import { walk } from './utils/walk'
import { plugin } from './plugin'
import { magic } from './magics'
import { store } from './store'
import { bind } from './binds'
import { data } from './datas'
import { setReactivityEngine, disableEffectScheduling, reactive, effect, release, raw, watch } from './reactivity.js'
import { mapAttributes, directive, setPrefix as prefix, prefix as prefixed } from './directives.js'
import { start, addRootSelector, addInitSelector, closestRoot, findClosest, initTree, destroyTree, interceptInit } from './lifecycle.js'
import { onElRemoved, onAttributeRemoved, onAttributesAdded, mutateDom, deferMutations, flushAndStopDeferringMutations, startObservingMutations, stopObservingMutations } from './mutation.js'
import { mergeProxies, closestDataStack, addScopeToNode, scope as $data } from './scope.js'
import { setEvaluator, evaluate, evaluateLater, dontAutoEvaluateFunctions } from './evaluator.js'
import { transition } from './directives/x-transition.js'
import { clone, cloneNode, skipDuringClone, onlyDuringClone, interceptClone } from './clone.js'
import { interceptor } from './interceptor.js'
import { getBinding as bound, extractProp } from './utils/bind.js'
import { debounce } from './utils/debounce.js'
import { throttle } from './utils/throttle.js'
import { setStyles } from './utils/styles.js'
import { entangle } from './entangle.js'
import { nextTick } from './nextTick.js'
import { walk } from './utils/walk.js'
import { plugin } from './plugin.js'
import { magic } from './magics.js'
import { store } from './store.js'
import { bind } from './binds.js'
import { data } from './datas.js'

let Alpine = {
get reactive() { return reactive },
Expand Down
2 changes: 1 addition & 1 deletion packages/alpinejs/src/binds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { attributesOnly, directives } from "./directives"
import { attributesOnly, directives } from "./directives.js"

let binds = {}

Expand Down
6 changes: 3 additions & 3 deletions packages/alpinejs/src/clone.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { effect, release, overrideEffect } from "./reactivity"
import { initTree, isRoot } from "./lifecycle"
import { walk } from "./utils/walk"
import { effect, release, overrideEffect } from "./reactivity.js"
import { initTree, isRoot } from "./lifecycle.js"
import { walk } from "./utils/walk.js"

export let isCloning = false

Expand Down
8 changes: 4 additions & 4 deletions packages/alpinejs/src/directives.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { onAttributeRemoved, onElRemoved } from './mutation'
import { evaluate, evaluateLater } from './evaluator'
import { elementBoundEffect } from './reactivity'
import Alpine from './alpine'
import { onAttributeRemoved, onElRemoved } from './mutation.js'
import { evaluate, evaluateLater } from './evaluator.js'
import { elementBoundEffect } from './reactivity.js'
import Alpine from './alpine.js'

let prefixAsString = 'x-'

Expand Down
40 changes: 20 additions & 20 deletions packages/alpinejs/src/directives/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
import { directive } from '../directives'
import { warn } from '../utils/warn'
import { directive } from '../directives.js'
import { warn } from '../utils/warn.js'

import './x-transition'
import './x-modelable'
import './x-teleport'
import './x-ignore'
import './x-effect'
import './x-model'
import './x-cloak'
import './x-init'
import './x-text'
import './x-html'
import './x-bind'
import './x-data'
import './x-show'
import './x-for'
import './x-ref'
import './x-if'
import './x-id'
import './x-on'
import './x-transition.js'
import './x-modelable.js'
import './x-teleport.js'
import './x-ignore.js'
import './x-effect.js'
import './x-model.js'
import './x-cloak.js'
import './x-init.js'
import './x-text.js'
import './x-html.js'
import './x-bind.js'
import './x-data.js'
import './x-show.js'
import './x-for.js'
import './x-ref.js'
import './x-if.js'
import './x-id.js'
import './x-on.js'

// Register warnings for people using plugin syntaxes and not loading the plugin itself:
warnMissingPluginDirective('Collapse', 'collapse', 'collapse')
Expand Down
10 changes: 5 additions & 5 deletions packages/alpinejs/src/directives/x-bind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { directive, into, mapAttributes, prefix, startingWith } from '../directives'
import { evaluateLater } from '../evaluator'
import { mutateDom } from '../mutation'
import bind from '../utils/bind'
import { applyBindingsObject, injectBindingProviders } from '../binds'
import { directive, into, mapAttributes, prefix, startingWith } from '../directives.js'
import { evaluateLater } from '../evaluator.js'
import { mutateDom } from '../mutation.js'
import bind from '../utils/bind.js'
import { applyBindingsObject, injectBindingProviders } from '../binds.js'

mapAttributes(startingWith(':', into(prefix('bind:'))))

Expand Down
4 changes: 2 additions & 2 deletions packages/alpinejs/src/directives/x-cloak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { directive, prefix } from '../directives'
import { mutateDom } from '../mutation'
import { directive, prefix } from '../directives.js'
import { mutateDom } from '../mutation.js'

directive('cloak', el => queueMicrotask(() => mutateDom(() => el.removeAttribute(prefix('cloak')))))
18 changes: 9 additions & 9 deletions packages/alpinejs/src/directives/x-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { directive, prefix } from '../directives'
import { initInterceptors } from '../interceptor'
import { injectDataProviders } from '../datas'
import { addRootSelector } from '../lifecycle'
import { interceptClone, isCloning, isCloningLegacy } from '../clone'
import { addScopeToNode } from '../scope'
import { injectMagics, magic } from '../magics'
import { reactive } from '../reactivity'
import { evaluate } from '../evaluator'
import { directive, prefix } from '../directives.js'
import { initInterceptors } from '../interceptor.js'
import { injectDataProviders } from '../datas.js'
import { addRootSelector } from '../lifecycle.js'
import { interceptClone, isCloning, isCloningLegacy } from '../clone.js'
import { addScopeToNode } from '../scope.js'
import { injectMagics, magic } from '../magics.js'
import { reactive } from '../reactivity.js'
import { evaluate } from '../evaluator.js'

addRootSelector(() => `[${prefix('data')}]`)

Expand Down
6 changes: 3 additions & 3 deletions packages/alpinejs/src/directives/x-effect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { skipDuringClone } from '../clone'
import { directive } from '../directives'
import { evaluate, evaluateLater } from '../evaluator'
import { skipDuringClone } from '../clone.js'
import { directive } from '../directives.js'
import { evaluate, evaluateLater } from '../evaluator.js'

directive('effect', skipDuringClone((el, { expression }, { effect }) => {
effect(evaluateLater(el, expression))
Expand Down
16 changes: 8 additions & 8 deletions packages/alpinejs/src/directives/x-for.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { addScopeToNode } from '../scope'
import { evaluateLater } from '../evaluator'
import { directive } from '../directives'
import { reactive } from '../reactivity'
import { initTree, destroyTree } from '../lifecycle'
import { mutateDom } from '../mutation'
import { warn } from '../utils/warn'
import { skipDuringClone } from '../clone'
import { addScopeToNode } from '../scope.js'
import { evaluateLater } from '../evaluator.js'
import { directive } from '../directives.js'
import { reactive } from '../reactivity.js'
import { initTree, destroyTree } from '../lifecycle.js'
import { mutateDom } from '../mutation.js'
import { warn } from '../utils/warn.js'
import { skipDuringClone } from '../clone.js'

directive('for', (el, { expression }, { effect, cleanup }) => {
let iteratorNames = parseForExpression(expression)
Expand Down
6 changes: 3 additions & 3 deletions packages/alpinejs/src/directives/x-html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { directive } from '../directives'
import { initTree } from '../lifecycle'
import { mutateDom } from '../mutation'
import { directive } from '../directives.js'
import { initTree } from '../lifecycle.js'
import { mutateDom } from '../mutation.js'

directive('html', (el, { expression }, { effect, evaluateLater }) => {
let evaluate = evaluateLater(expression)
Expand Down
6 changes: 3 additions & 3 deletions packages/alpinejs/src/directives/x-id.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { interceptClone } from "../clone"
import { directive } from "../directives"
import { setIdRoot } from '../ids'
import { interceptClone } from "../clone.js"
import { directive } from "../directives.js"
import { setIdRoot } from '../ids.js'

directive('id', (el, { expression }, { evaluate }) => {
let names = evaluate(expression)
Expand Down
14 changes: 7 additions & 7 deletions packages/alpinejs/src/directives/x-if.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { evaluateLater } from '../evaluator'
import { addScopeToNode } from '../scope'
import { directive } from '../directives'
import { initTree, destroyTree } from '../lifecycle'
import { mutateDom } from '../mutation'
import { warn } from "../utils/warn"
import { skipDuringClone } from '../clone'
import { evaluateLater } from '../evaluator.js'
import { addScopeToNode } from '../scope.js'
import { directive } from '../directives.js'
import { initTree, destroyTree } from '../lifecycle.js'
import { mutateDom } from '../mutation.js'
import { warn } from "../utils/warn.js"
import { skipDuringClone } from '../clone.js'

directive('if', (el, { expression }, { effect, cleanup }) => {
if (el.tagName.toLowerCase() !== 'template') warn('x-if can only be used on a <template> tag', el)
Expand Down
2 changes: 1 addition & 1 deletion packages/alpinejs/src/directives/x-ignore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { directive } from "../directives"
import { directive } from "../directives.js"

let handler = () => {}

Expand Down
6 changes: 3 additions & 3 deletions packages/alpinejs/src/directives/x-init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { directive, prefix } from "../directives";
import { addInitSelector } from "../lifecycle";
import { skipDuringClone } from "../clone";
import { directive, prefix } from "../directives.js";
import { addInitSelector } from "../lifecycle.js";
import { skipDuringClone } from "../clone.js";

addInitSelector(() => `[${prefix('init')}]`)

Expand Down
14 changes: 7 additions & 7 deletions packages/alpinejs/src/directives/x-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import bind, { isCheckbox, isRadio, safeParseBoolean } from '../utils/bind'
import { evaluateLater } from '../evaluator'
import { directive } from '../directives'
import { mutateDom } from '../mutation'
import { nextTick } from '../nextTick'
import { isCloning } from '../clone'
import on from '../utils/on'
import bind, { isCheckbox, isRadio, safeParseBoolean } from '../utils/bind.js'
import { evaluateLater } from '../evaluator.js'
import { directive } from '../directives.js'
import { mutateDom } from '../mutation.js'
import { nextTick } from '../nextTick.js'
import { isCloning } from '../clone.js'
import on from '../utils/on.js'

directive('model', (el, { modifiers, expression }, { effect, cleanup }) => {
let scopeTarget = el
Expand Down
4 changes: 2 additions & 2 deletions packages/alpinejs/src/directives/x-modelable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { directive } from '../directives'
import { entangle } from '../entangle';
import { directive } from '../directives.js'
import { entangle } from '../entangle.js';

directive('modelable', (el, { expression }, { effect, evaluateLater, cleanup }) => {
let func = evaluateLater(expression)
Expand Down
8 changes: 4 additions & 4 deletions packages/alpinejs/src/directives/x-on.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { directive, into, mapAttributes, prefix, startingWith } from '../directives'
import { evaluateLater } from '../evaluator'
import { skipDuringClone } from '../clone'
import on from '../utils/on'
import { directive, into, mapAttributes, prefix, startingWith } from '../directives.js'
import { evaluateLater } from '../evaluator.js'
import { skipDuringClone } from '../clone.js'
import on from '../utils/on.js'

mapAttributes(startingWith('@', into(prefix('on:'))))

Expand Down
4 changes: 2 additions & 2 deletions packages/alpinejs/src/directives/x-ref.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { closestRoot } from '../lifecycle'
import { directive } from '../directives'
import { closestRoot } from '../lifecycle.js'
import { directive } from '../directives.js'

function handler () {}

Expand Down
Loading