Fix x-ref crash during morph operations#4744
Closed
MichaelWest22 wants to merge 3 commits intoalpinejs:mainfrom
Closed
Fix x-ref crash during morph operations#4744MichaelWest22 wants to merge 3 commits intoalpinejs:mainfrom
MichaelWest22 wants to merge 3 commits intoalpinejs:mainfrom
Conversation
4 tasks
Collaborator
|
chose alternative solution in #4748 - thanks! fixed up now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix x-ref crash during morph operations
Problem
When morphing a child element (not the root
x-dataelement), Alpine crashes if that element containsx-refattributes. This breaks both Alpine's morph plugin and htmx's Alpine compatibility.The crash happens because morph creates temporary DOM fragments to prepare the new HTML. When Alpine initializes
x-refon elements in these fragments,closestRoot()returnsnullsince there's nox-dataancestor yet. The code then tries to accessroot._x_refs, causing a null reference error.Solution
Added a simple guard to return early when no root is found:
This lets
x-refgracefully skip initialization during the fragment preparation phase. Once the element is inserted into the actual DOM tree, Alpine properly initializes the ref with the correct root.Test
Added test case that morphs a child element containing
x-refto verify:$refsstill works after morph