Skip to content

Fix x-sort crash when container has a <template> with no .content #4819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshhanley wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −1
Open

Fix x-sort crash when container has a <template> with no .content #4819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f91ff47
Fix `x-sort` crash when container has a `<template>` with no `.content`
joshhanley Apr 20, 2026
a4f1edd
Unskip regression test
joshhanley Apr 20, 2026
bc77bbb
Update packages/sort/src/index.js
joshhanley Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sort/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function (Alpine) {
let preferences = {
hideGhost: ! modifiers.includes('ghost'),
useHandles: !! el.querySelector(handleSelector)
|| Array.from(el.querySelectorAll('template')).some(tmpl => tmpl.content.querySelector(handleSelector)),
|| Array.from(el.querySelectorAll('template:not(svg template)')).some(tmpl => tmpl.content?.querySelector(handleSelector)),
group: getGroupName(el, modifiers),
}

Expand Down
15 changes: 15 additions & 0 deletions tests/cypress/integration/plugins/sort.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,21 @@ test.skip('can use custom sortablejs configuration',
},
)

test('does not throw when a sort item contains a template inside an SVG',
[html`
<div x-data>
<ul x-sort>
<li id="1"><svg><template name="line"><path></path></template></svg>foo</li>
<li id="2">bar</li>
</ul>
</div>
`],
({ get }) => {
get('ul li').eq(0).should(haveText('foo'))
get('ul li').eq(1).should(haveText('bar'))
},
)

test.skip('works with Livewire morphing',
[html`
<div x-data>
Expand Down
Loading