ucm2: Sync Librem 5 config with Purism's downstream one #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config currently in this repo has several issues. The Purism downstream one resolves these. Taken from https://source.puri.sm/Librem5/librem5-base Commit f5b51beb144f76ef3bc483b74e19867bd6364d32
Contributor
|
cc @agx |
Member
|
From the first look this is very unclean update. Some modifications are straight, but the big ones seems a bit step back. Some comments: Header to Header1 is not finished (not all ConflictingDevices blocks were modified) |
Contributor
perexg
force-pushed
the
master
branch
2 times, most recently
from
c4285c8 to
b68aa52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The config currently in this repo has several issues. The Purism
downstream one resolves these.
Taken from https://source.puri.sm/Librem5/librem5-base, commit f5b51beb144f76ef3bc483b74e19867bd6364d32