feat: add Substack social link support#3528
Open
asboyer wants to merge 2 commits intoalshedivat:mainfrom
Open
Conversation
The jekyll-socials plugin now supports inline SVG icons (e.g., Substack) via fill='currentColor'. Since the theme styles font icons through i::before color rules, SVGs need equivalent fill rules to match. Add fill: var(--global-text-color) and hover fill: var(--global-theme-color) to SVG elements within social contact icons in both the about page and navbar.
Add substack_username case to the social links generator in metadata.liquid so Substack profiles are included in the schema.org sameAs array for SEO and structured data.
❌ Deploy Preview for relaxed-lollipop-b6bc17 failed. Why did it fail? →
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filland hoverfillrules for SVG elements in social contact icons (about page and navbar) so inline SVG icons match the existing font icon color/hover behaviorsubstack_usernameto the schema.orgsameAsgenerator inmetadata.liquidDepends on george-gca/jekyll-socials#4 which adds
substack_usernameas a built-in social platform with an inline SVG icon to the jekyll-socials plugin.Closes #3527
How it works
Once the jekyll-socials plugin is updated, users simply add to
_data/socials.yml:The plugin renders an inline SVG with
fill='currentColor', and the CSS changes in this PR ensure the SVG inherits the correct text color and theme color on hover — matching the behavior of existing font icons (i::beforerules).Why an inline SVG?
Font Awesome does not provide a Substack icon. The request (FortAwesome/Font-Awesome#16586) was open for 5 years before being closed without resolution. The jekyll-socials plugin introduces an
SVG_ICONScategory for platforms lacking font library support, using the official Substack logo path from Simple Icons.Screenshots
Light mode
Light mode (hover)
Dark mode
Dark mode (hover)
Test plan
substack_username: testuserto_data/socials.ymland verify the icon renders with correct color and hover behaviorsameAsmetadata includes the Substack URL