arch: mach-socfpga: cv_bsp_generator: fix support for Python3#12
Open
commodo wants to merge 1 commit intoaltera-fpga:socfpga_v2023.01from
Open
arch: mach-socfpga: cv_bsp_generator: fix support for Python3#12commodo wants to merge 1 commit intoaltera-fpga:socfpga_v2023.01from
commodo wants to merge 1 commit intoaltera-fpga:socfpga_v2023.01from
Conversation
Tested with generating a preloader for a DE10 nano board. On newer systems (like Arch) getting Python2 back in-there is a bit of a hassle (even if it is possible). Also, on newer versions of Ubuntu, this is also going to be a bit more difficult (over time). Luckily, the conversion to Python3 is just a few lines. A 'print' statement requires parentheses, and the 'unicode()' instantiation can be converted to 'str()'. The 'unicode()' class is a derivative of 'str()', which is required in Python2 for unicode string handling; though, it's unlikely we would need to generate unicode C definitions, so 'str()' should be fine. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Author
|
i'm a little confused here; i think the Github auto-message is from the uboot project; i am updating the if there's any other place to submit these changes, i am fine to adapt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with generating a preloader for a DE10 nano board.
On newer systems (like Arch) getting Python2 back in-there is a bit of a hassle (even if it is possible).
Also, on newer versions of Ubuntu, this is also going to be a bit more difficult (over time).
Luckily, the conversion to Python3 is just a few lines. A 'print' statement requires parentheses, and the 'unicode()' instantiation can be converted to 'str()'. The 'unicode()' class is a derivative of 'str()', which is required in Python2 for unicode string handling; though, it's unlikely we would need to generate unicode C definitions, so 'str()' should be fine.
Signed-off-by: Alexandru Ardelean alex@shruggie.ro