Enforce start codon + fix bug explicitly setting training data on command line#72
Open
LanderDC wants to merge 13 commits intoalthonos:mainfrom
Open
Enforce start codon + fix bug explicitly setting training data on command line#72LanderDC wants to merge 13 commits intoalthonos:mainfrom
LanderDC wants to merge 13 commits intoalthonos:mainfrom
Conversation
… improve validation for closed_start and closed_stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR handles #64 + I found a bug when specifying a custom training file for ORF prediction on a new sequence: even if a training file is specified,
pyrodigalwould retrain anyway and overwrite the training info.pyrodigal/src/pyrodigal/cli.py
Lines 271 to 278 in afebe63
Fixed with:
What has changed:
-cargument now takes one of the options "none" (default), "start" or "both". For backwards compatibility, specifying only-cis equal to-c bothwhich results in both a start and stop codon must be present.GeneFinderclassclosedargument should now be a list of two boolean values (again for backwards compatibility, if only one is given the newclosed_startandclosed_stoparguments will take that value).test_extract_edge_start()because theextractfunction does not take theclosedargument anymore