1.5.5 final PR : transcription sound added to record start ; notch delay reduced #119
1.5.5 final PR : transcription sound added to record start ; notch delay reduced #119
Conversation
- Add optional audio feedback when recording starts (enabled by default) - Settings toggle for Transcription Sounds with two sound options - Play start sound consistently across dictation, command, and rewrite modes - Add TranscriptionSoundPlayer singleton with AVAudioPlayer caching
…od gitignore to let m4a ext ; updated version to 1.5.5
Add a transcription start sound across dictation, command, and rewrite modes and reduce overlay notch delay to 30 ms in
|
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
| if providerID == "fluid-1" { | ||
| if self.expandedProviderID == providerID { |
There was a problem hiding this comment.
When expanding fluid-1 while a regular provider is expanded, the early return skips calling setEditingAPIKey(false, ...) for the previous provider. Consider clearing the editing state before the early return.
- if providerID == "fluid-1" {
- if self.expandedProviderID == providerID {
+ if providerID == "fluid-1" {
+ if let previousID = self.expandedProviderID, previousID != "fluid-1" {
+ self.viewModel.setEditingAPIKey(false, for: previousID)
+ }
+ if self.expandedProviderID == providerID {🚀 Want me to fix this? Reply ex: "fix it for me".
| } | ||
|
|
||
| private func submitFluid1Interest() { | ||
| guard !self.settings.fluid1InterestCaptured else { return } |
There was a problem hiding this comment.
Consider also guarding against fluid1InterestIsSubmitting being true to prevent potential concurrent submissions.
| guard !self.settings.fluid1InterestCaptured else { return } | |
| guard !self.settings.fluid1InterestCaptured, !self.fluid1InterestIsSubmitting else { return } |
🚀 Want me to fix this? Reply ex: "fix it for me".
|
|
||
| do { | ||
| var request = URLRequest(url: url) | ||
| request.httpMethod = "POST" |
There was a problem hiding this comment.
Consider adding a timeoutInterval to the request (e.g., request.timeoutInterval = 15) so the spinner doesn't hang for 60 seconds if the server is unresponsive.
| request.httpMethod = "POST" | |
| request.httpMethod = "POST" | |
| request.timeoutInterval = 15 |
🚀 Want me to fix this? Reply ex: "fix it for me".
2 participants
Description
Added option to add recording start chime sound + options to choose from.
Type of Change
Related Issues
#86 #111
Testing
brew install swiftlint && swiftlint --strict --config .swiftlint.ymlbrew install swiftformat && swiftformat --config .swiftformat SourcesScreenshots / Video
Add screenshots or Video recording of the app after you have made your changes