Skip to content

UI changes ; notch bug fix#120

Merged
altic-dev merged 2 commits intomainfrom
b/UI
Jan 26, 2026
Merged

UI changes ; notch bug fix#120
altic-dev merged 2 commits intomainfrom
b/UI

Conversation

@altic-dev
Copy link
Owner

@altic-dev altic-dev commented Jan 26, 2026

Description

UI changes ; notch bug fix

Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update

Related Issues

Closes #(issue number)

Testing

  • Tested on Intel/Apple Silicon Mac
  • Tested on Apple Silicon Mac
  • Tested on macOS [version]
  • Ran linter locally: brew install swiftlint && swiftlint --strict --config .swiftlint.yml
  • Ran formatter locally: brew install swiftformat && swiftformat --config .swiftformat Sources

Screenshots / Video

Add screenshots or Video recording of the app after you have made your changes

@macroscopeapp
Copy link
Contributor

macroscopeapp bot commented Jan 26, 2026

Adjust Fluid UI onboarding flow by deferring ContentView.selectedSidebarItem initialization and routing Escape/close actions to Preferences or Welcome, and reduce Notch glow to lower intensity and radii

Set default sidebar selection at runtime based on ASR/model readiness, reorder sidebar entries by onboarding state, route Command/Rewrite close to Preferences or Welcome, default overlay position to bottom, cache SettingsView.FlowLayout measurements with a 260 max-width fallback, and lower Notch waveform glow values.

📍Where to Start

Start in ContentView.body for selection and routing logic in ContentView.swift.


📊 Macroscope summarized 81ad0a7. 5 files reviewed, 4 issues evaluated, 3 issues filtered, 1 comment posted. View details

// Set default selection if none exists (from menu bar navigation)
// Show Preferences as default once voice model is ready (AI enhancement is optional)
if self.selectedSidebarItem == nil {
let isOnboarded = self.asr.isAsrReady || self.asr.modelsExistOnDisk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accessing self.asr.isAsrReady and self.asr.modelsExistOnDisk at lines 169-170 occurs before the 1.5s startup delay at line 190, potentially bypassing the defensive startup gate documented in lines 181-189. Consider moving this check inside the DispatchQueue.main.asyncAfter block to ensure ASR properties aren't accessed until after signalUIReady().

🚀 Want me to fix this? Reply ex: "fix it for me".

@altic-dev altic-dev merged commit e7fc98e into main Jan 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant