Conversation
github-actions
bot
added
documentation
riscait
requested review from
Copilot,
k-nkmr and
naipaka
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades Flutter to version 3.35.3 with Dart 3.9.2 and modernizes the dependency management system by transitioning from CocoaPods to Flutter's native dependency management with Swift Package Manager for iOS platforms.
- Removes CocoaPods dependencies and switches to Swift Package Manager
- Updates Firebase packages and resolves dependency conflicts
- Replaces deprecated DeviceFrameAddon with ViewportAddon in widget catalog
Reviewed Changes
Copilot reviewed 32 out of 36 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Updates Flutter SDK version and removes dependency overrides |
| packages/flutter_app/pubspec.yaml | Updates Firebase packages and adds new Firebase services |
| packages/widget_catalog/lib/main.dart | Replaces DeviceFrameAddon with ViewportAddon |
| packages/flutter_app/ios/Podfile | Removes CocoaPods configuration entirely |
| packages/flutter_app/ios/ci_scripts/ci_post_clone.sh | Updates CI script to remove CocoaPods installation |
| .fvmrc | Updates Flutter version to 3.35.3 |
Files not reviewed (1)
- packages/flutter_app/ios/Runner.xcworkspace/contents.xcworkspacedata: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| itemBuilder: (_, index) { | ||
| final themeMode = ThemeMode.values[index]; | ||
| return RadioListTile<ThemeMode>( | ||
| value: themeMode, |
There was a problem hiding this comment.
The RadioListTile is missing the groupValue and onChanged properties after being wrapped in RadioGroup. These properties should be removed from individual RadioListTiles when using RadioGroup as the parent handles the group behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🙌 What's Done
✍️ What's Not Done
📝 Additional Notes
Pre-launch Checklist