Add linting job

.editorconfig

@@ -1,7 +1,7 @@
 
 [*]
 charset=utf-8
-end_of_line=crlf
+end_of_line=lf
 trim_trailing_whitespace=false
 insert_final_newline=false
 indent_style=space

.github/linters/.flake8

@@ -0,0 +1,6 @@
+[flake8]
+max-line-length = 120
+
+per-file-ignores =
+    */__init__.py:F401,F403
+    */keycode.py:E741

.github/linters/sun_checks.xml

@@ -0,0 +1,190 @@
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+          "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+          "https://checkstyle.org/dtds/configuration_1_3.dtd">
+
+<!--
+  Checkstyle configuration that checks the sun coding conventions from:
+    - the Java Language Specification at
+      https://docs.oracle.com/javase/specs/jls/se11/html/index.html
+    - the Sun Code Conventions at https://www.oracle.com/java/technologies/javase/codeconventions-contents.html
+    - the Javadoc guidelines at
+      https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html
+    - the JDK Api documentation https://docs.oracle.com/en/java/javase/11/
+    - some best practices
+  Checkstyle is very configurable. Be sure to read the documentation at
+  https://checkstyle.org (or in your downloaded distribution).
+  Most Checks are configurable, be sure to consult the documentation.
+  To completely disable a check, just comment it out or delete it from the file.
+  To suppress certain violations please review suppression filters.
+  Finally, it is worth reading the documentation.
+-->
+
+<module name="Checker">
+  <!--
+      If you set the basedir property below, then all reported file
+      names will be relative to the specified directory. See
+      https://checkstyle.org/config.html#Checker
+      <property name="basedir" value="${basedir}"/>
+  -->
+  <property name="severity" value="error"/>
+
+  <property name="fileExtensions" value="java, properties, xml"/>
+
+  <!-- Excludes all 'module-info.java' files              -->
+  <!-- See https://checkstyle.org/config_filefilters.html -->
+  <module name="BeforeExecutionExclusionFileFilter">
+    <property name="fileNamePattern" value="module\-info\.java$"/>
+  </module>
+
+  <!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
+  <module name="SuppressionFilter">
+    <property name="file" value="${org.checkstyle.sun.suppressionfilter.config}" default="checkstyle-suppressions.xml" />
+    <property name="optional" value="true"/>
+  </module>
+
+  <!-- Checks that a package-info.java file exists for each package.     -->
+  <!-- See https://checkstyle.org/config_javadoc.html#JavadocPackage -->
+  <!-- TODO: Uncomment the following module after adding Javadocs -->
+  <!-- <module name="JavadocPackage"/> -->
+
+  <!-- Checks whether files end with a new line.                        -->
+  <!-- See https://checkstyle.org/config_misc.html#NewlineAtEndOfFile -->
+  <module name="NewlineAtEndOfFile"/>
+
+  <!-- Checks that property files contain the same keys.         -->
+  <!-- See https://checkstyle.org/config_misc.html#Translation -->
+  <module name="Translation"/>
+
+  <!-- Checks for Size Violations.                    -->
+  <!-- See https://checkstyle.org/config_sizes.html -->
+  <module name="FileLength"/>
+  <module name="LineLength">
+    <property name="fileExtensions" value="java"/>
+    <property name="max" value="120"/>
+  </module>
+
+  <!-- Checks for whitespace                               -->
+  <!-- See https://checkstyle.org/config_whitespace.html -->
+  <module name="FileTabCharacter"/>
+
+  <!-- Miscellaneous other checks.                   -->
+  <!-- See https://checkstyle.org/config_misc.html -->
+  <module name="RegexpSingleline">
+    <property name="format" value="\s+$"/>
+    <property name="minimum" value="0"/>
+    <property name="maximum" value="0"/>
+    <property name="message" value="Line has trailing spaces."/>
+  </module>
+
+  <!-- Checks for Headers                                -->
+  <!-- See https://checkstyle.org/config_header.html   -->
+  <!-- <module name="Header"> -->
+  <!--   <property name="headerFile" value="${checkstyle.header.file}"/> -->
+  <!--   <property name="fileExtensions" value="java"/> -->
+  <!-- </module> -->
+
+  <!-- Enables @SuppressWarnings Support                -->
+  <module name="SuppressWarningsFilter"/>
+  <module name="TreeWalker">
+
+    <!-- Checks for Javadoc comments.                     -->
+    <!-- See https://checkstyle.org/config_javadoc.html -->
+    <module name="InvalidJavadocPosition"/>
+    <!-- TODO: Uncomment the following four modules after adding Javadocs -->
+    <!-- <module name="JavadocMethod"/> -->
+    <!-- <module name="JavadocType"/> -->
+    <!-- <module name="JavadocVariable"/> -->
+    <!-- <module name="MissingJavadocMethod"/> -->
+    <module name="JavadocStyle"/>
+    <!-- Enables @SuppressWarnings Support                -->
+    <module name="SuppressWarningsHolder"/>
+
+    <!-- Checks for Naming Conventions.                  -->
+    <!-- See https://checkstyle.org/config_naming.html -->
+    <module name="ConstantName"/>
+    <module name="LocalFinalVariableName"/>
+    <module name="LocalVariableName"/>
+    <module name="MemberName"/>
+    <module name="MethodName"/>
+    <module name="PackageName"/>
+    <module name="ParameterName"/>
+    <module name="StaticVariableName"/>
+    <module name="TypeName"/>
+
+    <!-- Checks for imports                              -->
+    <!-- See https://checkstyle.org/config_imports.html -->
+    <module name="AvoidStarImport"/>
+    <module name="IllegalImport"/>
+    <!-- defaults to sun.* packages -->
+    <module name="RedundantImport"/>
+    <module name="UnusedImports">
+      <property name="processJavadoc" value="false"/>
+    </module>
+
+    <!-- Checks for Size Violations.                    -->
+    <!-- See https://checkstyle.org/config_sizes.html -->
+    <module name="MethodLength"/>
+    <module name="ParameterNumber"/>
+
+    <!-- Checks for whitespace                               -->
+    <!-- See https://checkstyle.org/config_whitespace.html -->
+    <module name="EmptyForIteratorPad"/>
+    <module name="GenericWhitespace"/>
+    <module name="MethodParamPad"/>
+    <module name="NoWhitespaceAfter"/>
+    <module name="NoWhitespaceBefore"/>
+    <module name="OperatorWrap"/>
+    <module name="ParenPad"/>
+    <module name="TypecastParenPad"/>
+    <module name="WhitespaceAfter"/>
+    <module name="WhitespaceAround"/>
+
+    <!-- Modifier Checks                                    -->
+    <!-- See https://checkstyle.org/config_modifiers.html -->
+    <module name="ModifierOrder"/>
+    <module name="RedundantModifier"/>
+
+    <!-- Checks for blocks. You know, those {}'s         -->
+    <!-- See https://checkstyle.org/config_blocks.html -->
+    <module name="AvoidNestedBlocks"/>
+    <module name="EmptyBlock"/>
+    <module name="LeftCurly"/>
+    <module name="NeedBraces"/>
+    <module name="RightCurly"/>
+
+    <!-- Checks for common coding problems               -->
+    <!-- See https://checkstyle.org/config_coding.html -->
+    <module name="EmptyStatement"/>
+    <module name="EqualsHashCode"/>
+    <!-- <module name="HiddenField"/> -->
+    <module name="IllegalInstantiation"/>
+    <module name="InnerAssignment"/>
+    <module name="MagicNumber"/>
+    <module name="MissingSwitchDefault"/>
+    <module name="MultipleVariableDeclarations"/>
+    <module name="SimplifyBooleanExpression"/>
+    <module name="SimplifyBooleanReturn"/>
+
+    <!-- Checks for class design                         -->
+    <!-- See https://checkstyle.org/config_design.html -->
+    <module name="DesignForExtension"/>
+    <module name="FinalClass"/>
+    <module name="HideUtilityClassConstructor"/>
+    <module name="InterfaceIsType"/>
+    <module name="VisibilityModifier"/>
+
+    <!-- Miscellaneous other checks.                   -->
+    <!-- See https://checkstyle.org/config_misc.html -->
+    <module name="ArrayTypeStyle"/>
+    <module name="FinalParameters"/>
+    <module name="TodoComment"/>
+    <module name="UpperEll"/>
+
+    <!-- https://checkstyle.org/config_filters.html#SuppressionXpathFilter -->
+    <module name="SuppressionXpathFilter">
+      <property name="file" value="${org.checkstyle.sun.suppressionxpathfilter.config}" default="checkstyle-xpath-suppressions.xml" />
+      <property name="optional" value="true"/>
+    </module>
+  </module>
+</module>

.github/workflows/push.yml

@@ -7,6 +7,21 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  lint:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Lint Code Base
+        uses: github/super-linter@v4
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          VALIDATE_JAVA: true
+          VALIDATE_PYTHON_FLAKE8: true
+          # VALIDATE_CSHARP: false
+          FILTER_REGEX_EXCLUDE: .*Docs/**/*.[py|cs|java]
+
   build-docs:
     runs-on: ubuntu-latest
 

Assets/AltTester/AltDriver/AltDevice.cs

@@ -19,5 +19,4 @@ public AltDevice(string deviceId, string platform, int localPort = 13000, int re
             Pid = pid;
         }
     }
-}
-
+}

Assets/AltTester/AltDriver/AltDriver.cs

@@ -581,4 +581,4 @@ public void RemoveNotificationListener(NotificationType notificationType)
             new RemoveNotificationListener(communicationHandler, notificationType).Execute();
         }
     }
-}
+}

Assets/AltTester/AltDriver/AltErrors.cs

@@ -407,4 +407,4 @@ public ResponseFormatException(Type t, string data) : base("Could not deserializ
 
         }
     }
-}
+}

Assets/AltTester/AltDriver/AltPortForwarding.cs

@@ -347,5 +347,4 @@ private static Process startProcess(string processPath, string arguments)
             return process;
         }
     }
-}
-
+}

Assets/AltTester/AltDriver/Commands/AltCommands/AddNotificationListener.cs

@@ -23,4 +23,4 @@ public void Execute()
             ValidateResponse("Ok", data);
         }
     }
-}
+}

Assets/AltTester/AltDriver/Commands/AltCommands/AltSetServerLogging.cs

@@ -17,4 +17,4 @@ public void Execute()
             ValidateResponse("Ok", data);
         }
     }
-}
+}

Assets/AltTester/AltDriver/Commands/AltCommands/RemoveNotificationListener.cs

@@ -19,4 +19,4 @@ public void Execute()
             ValidateResponse("Ok", data);
         }
     }
-}
+}

Assets/AltTester/AltDriver/Commands/DriverCommunicationWebSocket.cs

@@ -350,4 +350,4 @@ public void SleepFor(float time)
             Thread.Sleep(System.Convert.ToInt32(time * 1000));
         }
     }
-}
+}

Assets/AltTester/AltDriver/Commands/FindObjects/AltFindObjectsWhichContain.cs

@@ -15,4 +15,4 @@ public System.Collections.Generic.List<AltObject> Execute()
             return ReceiveListOfAltObjects(cmdParams);
         }
     }
-}
+}

Assets/AltTester/AltDriver/Commands/IDriverCommunication.cs

@@ -16,4 +16,4 @@ public interface IDriverCommunication
         float GetDelayAfterCommand();
         void SleepFor(float time);
     }
-}
+}

Assets/AltTester/AltDriver/Commands/ObjectCommands/AltObjectAction.cs

@@ -9,7 +9,6 @@ public struct AltObjectAction
         public string Method;
         public string Parameters;
         public string TypeOfParameters;
-
         public AltObjectAction(string component = "", string method = "", string parameters = "", string typeOfParameters = "", string assembly = "")
         {
             Component = component;
@@ -18,8 +17,6 @@ public AltObjectAction(string component = "", string method = "", string paramet
             TypeOfParameters = typeOfParameters;
             Assembly = assembly;
         }
-
-
         public string Assembly;
     }
 }

Assets/AltTester/AltDriver/Commands/Screenshot/AltGetScreenshot.cs

@@ -73,5 +73,4 @@ public AltTextureInformation Execute(out AltObject selectedObject)
 
         }
     }
-
 }

Assets/AltTester/AltDriver/Common/AltAxis.cs

@@ -18,4 +18,4 @@ public AltAxis(string name, string negativeButton, string positiveButton, string
             this.altNegativeButton = altNegativeButton;
         }
     }
-}
+}

Assets/AltTester/AltDriver/Common/AltObject.cs

@@ -214,4 +214,4 @@ public System.Collections.Generic.List<string> GetAllMethods(AltComponent altCom
             return altObject;
         }
     }
-}
+}

Assets/AltTester/AltDriver/Logging/AltLogLevel.cs

@@ -11,6 +11,4 @@ public enum AltLogLevel
         Fatal = 5,
         Off = 6,
     }
-
-
 }

Assets/AltTester/AltDriver/Logging/UnityTarget.cs

@@ -34,6 +34,5 @@ protected override void Write(LogEventInfo logEvent)
             }
         }
     }
-
 }
 #endif

Assets/AltTester/AltDriver/UnityStruct/AltKeyCode.cs

@@ -323,4 +323,4 @@ public enum AltKeyCode
         Joystick8Button18 = 508,
         Joystick8Button19 = 509
     }
-}
+}

Assets/AltTester/AltDriver/UnityStruct/AltVector.cs

@@ -109,4 +109,4 @@ public override string ToString()
             return base.ToString();
         }
     }
-}
+}

Bindings~/java/pom.xml

@@ -55,7 +55,7 @@
         <maven.compiler.version>3.3</maven.compiler.version>
         <maven.surefire.version>2.22.1</maven.surefire.version>
         <mockito.version>1.10.19</mockito.version>
-        <lombok.version>1.18.2</lombok.version>
+        <lombok.version>1.18.26</lombok.version>
     </properties>
 
     <dependencies>
@@ -112,7 +112,7 @@
             <artifactId>tyrus-standalone-client</artifactId>
             <version>1.9</version>
         </dependency>
-    
+
       <dependency>
         <groupId>org.junit.jupiter</groupId>
         <artifactId>junit-jupiter-api</artifactId>