Conversation
Replace Bool return + puts error handling with VerifyStatus enum. Add public_key parameter to bypass DNS for unit testing. Extract verify_one for per-signature logic and verify_all for multi-sig. Verification fixes: v=1 validation, c= body default to simple, x= expiration, p= key revocation, l= body length truncation, iterate all DKIM-Signature headers. Signing: add body_length parameter for l= tag support. 19 new verification specs using sign-then-verify pattern. Add GitHub Actions CI (Crystal 1.19 + latest). Bump version to 0.3.0.
Fixes EVP_PKEY_size linker error on OpenSSL 3.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boolreturn +putswithVerifyStatusenum (Pass,Fail,BodyHashFail,KeyRevoked,Expired,NoSignature,NoKey,InvalidSig)public_keyparameter toverify/verify_allto bypass DNS for unit testingv=1validation,c=body default,x=expiration,p=key revocation,l=body length, multiple signaturesbody_lengthsigning support forl=tagTest plan
crystal spec— 29 examples, 0 failurescrystal build --no-codegen src/dkimvrfy.cr— type-checkscrystal build --no-codegen src/dkimsign.cr— type-checks