Skip to content

Added ability to setExtraHTTPHeaders #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Added ability to setExtraHTTPHeaders #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc2e11b
Added ability to setExtraHTTPHeaders
Aug 7, 2018
eabda91
Switched tabs to spaces
Aug 7, 2018
1c074f9
This fixes #61
Aug 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ The only required parameter is `url`.
// Passed to Puppeteer page.waitFor()
waitFor: null,

// Passsed to Puppeteer page.setCookies()
// Passed to Puppeteer page.setCookies()
cookies: [{ ... }]

// Passed to Puppeteer page.setViewport()
Expand All @@ -228,6 +228,9 @@ The only required parameter is `url`.

// Passed to Puppeteer page.pdf()
pdf: { ... }

// Passed to Puppeteer page.setExtraHTTPHeaders()
setExtraHTTPHeaders: { "key": "value" }
}
```

Expand Down
4 changes: 4 additions & 0 deletions src/core/pdf-core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ async function render(_opts = {}) {
printBackground: true,
},
failEarly: false,
setExtraHTTPHeaders: {},
}, _opts);

if (_.get(_opts, 'pdf.width') && _.get(_opts, 'pdf.height')) {
Expand Down Expand Up @@ -80,6 +81,9 @@ async function render(_opts = {}) {
opts.cookies.map(async (cookie) => {
await page.setCookie(cookie);
});

logger.info('Setting headers...');
await page.setExtraHTTPHeaders(opts.setExtraHTTPHeaders);

if (opts.html) {
logger.info('Set HTML ..');
Expand Down
2 changes: 2 additions & 0 deletions src/util/validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ const sharedQuerySchema = Joi.object({
'pdf.margin.bottom': Joi.string().min(1).max(2000),
'pdf.margin.left': Joi.string().min(1).max(2000),
'pdf.printBackground': Joi.boolean(),
setExtraHTTPHeaders: Joi.object(),
});

const renderQuerySchema = Joi.object({
Expand Down Expand Up @@ -104,6 +105,7 @@ const renderBodyObject = Joi.object({
printBackground: Joi.boolean(),
}),
failEarly: Joi.string(),
setExtraHTTPHeaders: Joi.object(),
});

const renderBodySchema = Joi.alternatives([
Expand Down