Fix quantization_config parsing for --kv-cache-dtype=auto#32
Merged
alvarobartt merged 10 commits intomainfrom Feb 4, 2026
Merged
Fix quantization_config parsing for --kv-cache-dtype=auto#32alvarobartt merged 10 commits intomainfrom
quantization_config parsing for --kv-cache-dtype=auto#32alvarobartt merged 10 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Warning
This PR constitutes a breaking change given that as there was a bug before with the parsing order where
dtype(andtorch_dtype) where being parsed as the default--kv-cache-dtypewhen--kv-cache-dtype=auto(or simply not set); the actual dtype from thequantization_configwas not being used as the default option, meaning that now models with adtypeortorch_dtypeset with an invalidquantization_configwill raise aRuntimeErrorwhereas before those where working "fine", just estimating the KV cache requirements with a "wrong" dtype.This PR fixes the placement of the
quantization_configto have more priority if there thandtypeortorch_dtype, as well as bumping the version to 0.4.4 withuv version 0.4.4.CONTRIBUTING.md.