feat: expand TOML reader/writer with comprehensive tests#40
Merged
Conversation
- Add from_reader() for parsing TOML from io::Read sources - Enforce top-level table constraint in to_string() for all non-map types - Add 40+ tests covering: basic key-value pairs, nested/dotted tables, arrays of tables, inline tables, datetime types (offset/local/date/time), integer formats (hex/octal/binary), multiline strings (basic/literal), cross-format roundtrips (JSON↔TOML, YAML↔TOML), top-level constraint errors for arrays/scalars/strings/bools/null, invalid TOML parsing, from_reader, empty documents, unicode, null representation, float edge cases (inf/nan), quoted keys, and complex roundtrips Fixes #10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #10 — TOML reader/writer.
Changes
New functionality:
from_reader(): Parse TOML from anyio::Readsource.to_string()now explicitly rejects all non-table top-level values (scalars, arrays, strings, bools, null) with a clear error message.New tests (40+):
[[table]])""") and literal ('''), plus roundtripfrom_reader()for simple and nested docsAll checks pass:
cargo build,cargo test(210 tests),cargo fmt --check,cargo clippy -D warnings.