Skip to content

changes from development of DscGit #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

changes from development of DscGit #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4402dce
replace Get- and Get-Normalized with Test-
alx9r Aug 4, 2017
712a0cf
use terser command names in fixture
alx9r Aug 4, 2017
e444205
use Test- instead of Get-
alx9r Aug 4, 2017
f70922e
move processPersistentItem.ps1 to ToolFoundations
alx9r Aug 4, 2017
63dbe42
test resource plumbing
alx9r Aug 13, 2017
a150676
test for extraneous static-typing in resource plumbing
alx9r Aug 13, 2017
51cf582
use new ZeroDsc local variable capability
alx9r Aug 14, 2017
97bfc30
use .Net enums instead of PowerShell enums
alx9r Aug 15, 2017
1e443cb
use $null instead of 'DoNotSet'
alx9r Aug 15, 2017
334dbf2
test for default properties
alx9r Aug 16, 2017
2e7111d
more public interface testing
alx9r Aug 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 7 additions & 19 deletions Functions/processPersistentItem.ps1 → External/processPersistentItem-564a734 .ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,16 @@ function Invoke-ProcessPersistentItem
[hashtable]
$Properties,

[Parameter(ParameterSetName = 'with_properties',
Mandatory = $true)]
[string]
$PropertyGetter,

[Parameter(ParameterSetName = 'with_properties',
Mandatory = $true)]
[string]
$PropertySetter,


[Parameter(ParameterSetName = 'with_properties',
Mandatory = $true)]
[string]
$PropertyNormalizer
$PropertyTester
)
process
{
Expand Down Expand Up @@ -103,9 +99,8 @@ function Invoke-ProcessPersistentItem
Mode = $Mode
Keys = $_Keys
Properties = $Properties
PropertyGetter = $PropertyGetter
PropertySetter = $PropertySetter
PropertyNormalizer = $PropertyNormalizer
PropertyTester = $PropertyTester
}
Invoke-ProcessPersistentItemProperty @splat
}
Expand All @@ -129,17 +124,13 @@ function Invoke-ProcessPersistentItemProperty
[hashtable]
$Properties,

[Parameter(Mandatory = $true)]
[string]
$PropertyGetter,

[Parameter(Mandatory = $true)]
[string]
$PropertySetter,

[Parameter(Mandatory = $true)]
[string]
$PropertyNormalizer
$PropertyTester
)
process
{
Expand All @@ -149,13 +140,10 @@ function Invoke-ProcessPersistentItemProperty
# this is the desired value provided by the user
$desired = $Properties.$propertyName

# normalize the desired value
$normalized = & $PropertyNormalizer -PropertyName $propertyName -Value $desired

# get the existing value
$existing = & $PropertyGetter @_Keys -PropertyName $propertyName
# test for the desired value
$alreadyCorrect = & $PropertyTester @_Keys -PropertyName $propertyName -Value $desired

if ( $existing -ne $normalized )
if ( -not $alreadyCorrect )
{
if ( $Mode -eq 'Test' )
{
Expand Down
1 change: 0 additions & 1 deletion Functions/loadTypes.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@
'shellLibraryType.ps1'
'shellLibraryFolderType.ps1'
'stockIconInfoType.ps1'
'shortcutType.ps1'
) |
% { . "$($PSCommandPath | Split-Path -Parent)\$_" }
312 changes: 0 additions & 312 deletions Functions/processPersistentItem.Tests.ps1
View file
Open in desktop

This file was deleted.

Loading