Profile endpoints extracted from PR #336

[m0veax]

Hi There,

i found PR #336 and started extracting the Profile Endpoints.

I removed duplicate Code, refactored Typehints and Typos. My next step is to write the needed tests and add it to the docs afterwards.

Hope anyone can use it :)

[coveralls]

Coverage decreased (-0.8%) to 99.059% when pulling cc88b57 on proappers:profileEndpoints into b072260 on amabnl:master.

[bimusiek]

Hey @m0veax, thanks for contributing.
Do you think is it possible to add tests for coverage and fix scrutinizer issues?

I would love to have your code merged. 👍

[m0veax]

Hi,

yeah i have to, otherwise it wouldn't get merged and I loose my update ability in my own usage.

But I decided to focus on Readprofile and search by name and will rearrange the pull request that way.

Getting the class structure converted to the needed xml is new for me and some kind of PITA right now. Maybe the docs of this lib should be extended about this topic?

[m0veax]

Can someone point me to the place where the class Structures get converted to XML?

I have some converting Issues and can't really find a manual or some other informations.

[DerMika]

Unfortunately that's the magic of PHP's SoapClient library, which uses the C library libxml2 underneath..

[m0veax]

Ah, so it is a native PHP feature and not something developed in your library. I tried to find some, but do you know any documentation about how that happens?

[DerMika]

I know you can provide a classpath map to explicitly try to map objects from the WSDL to PHP classes, but there's a lot of trial and error in the whole process I'm afraid... My resources were mainly Google & Stackoverflow :)

[m0veax]

Thanks for your blazing fast replies. I will dive into it. Hopefully I get this done until the end of next month. I don't have much spare time at the moment, but I want to learn more about tests and your PR rules are fitting that case for me :)

I will commit again when I build a valid soap message to find profiles by name.

Please don't add a milestone yet

[m0veax]

I feel like i am near to get reading a profile by freetext name search done.

But how should i interpret this Error in the PHP SOAP context?

Object of class Amadeus\Client\RequestOptions\Profile\FreeTextSearchOptions could not be converted to string

I'm sure that i should not add a toString magic method.

[DerMika]

FreeTextSearchOptions is a requestOptions object, which is something that should be used to BUILD the message (messages should be namespace Amadeus\Client\Struct*)

so you probably did something wrong converting the request options to the structs which are used to build the XML document.

[m0veax]

Hey,

thanks for your input. I found a way to send a valid message and get a valid response. I am soon working on my next commit to this PR.

So, this is still alive and i'm still working on it.

[DerMika]

allright, thanks!