wishbone.bus.Decoder: Only assert stb when slave is selected#31
Open
antonblanchard wants to merge 1 commit intoamaranth-lang:mainfrom
Open
wishbone.bus.Decoder: Only assert stb when slave is selected#31antonblanchard wants to merge 1 commit intoamaranth-lang:mainfrom
antonblanchard wants to merge 1 commit intoamaranth-lang:mainfrom
Conversation
While a slave should check both cyc and stb are asserted, it is a bit odd that we assert stb on all slaves even if they are not selected. This changes stb to behave like the cyc signal, and adds a few tests.
Contributor
Author
|
The wishbone spec mentions this about the |
Member
|
Sorry for this very late response. The Wishbone spec also says that interface signals are only valid if
AFAIU, this allows If this behavior is incompatible with other implementations, I don't mind changing it. Could you rebase this PR to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While a slave should check both cyc and stb are asserted, it is a bit
odd that we assert stb on all slaves even if they are not selected.
This changes stb to behave like the cyc signal, and adds a few tests.