Skip to content

sim.pysim: Only close VCD/GTKW files if we opened them ourselves. #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2024
Merged

sim.pysim: Only close VCD/GTKW files if we opened them ourselves. #1156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions amaranth/sim/pysim.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,14 @@ def __init__(self, fragment, *, vcd_file, gtkw_file=None, traces=()):
# the simulator is still usable if it's not installed for some reason.
import vcd, vcd.gtkw

self.close_vcd = False
self.close_gtkw = False
if isinstance(vcd_file, str):
vcd_file = open(vcd_file, "w")
self.close_vcd = True
if isinstance(gtkw_file, str):
gtkw_file = open(gtkw_file, "w")
self.close_gtkw = True

self.vcd_signal_vars = SignalDict()
self.vcd_memory_vars = {}
Expand Down Expand Up @@ -189,9 +193,9 @@ def close(self, timestamp):
else:
assert False # :nocov:

if self.vcd_file is not None:
if self.close_vcd:
self.vcd_file.close()
if self.gtkw_file is not None:
if self.close_gtkw:
self.gtkw_file.close()


Expand Down