This repository was archived by the owner on Sep 24, 2021. It is now read-only.
Let it work when no metadata is available#79
Open
BEvgeniyS wants to merge 1 commit intoamazon-archives:masterfrom
Open
Let it work when no metadata is available#79BEvgeniyS wants to merge 1 commit intoamazon-archives:masterfrom
BEvgeniyS wants to merge 1 commit intoamazon-archives:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per EKS security best practices, we'd like to restrict access to EC2 metadata. Serviceaccount roles allow to assume IAM roles by pods.
Unless I'm missing something, there's no reason for the program to fail when there's no metadata
This adds an option to override the region using standard environment variables -
AWS_DEFAULT_REGIONorAWS_REGIONBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.