forked from babelfish-for-postgresql/babelfish_extensions
-
Notifications
You must be signed in to change notification settings - Fork 2
Adding Grantor Information in sys.babelfish_schema_permissions catalog #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shreyeah38
wants to merge
22
commits into
amazon-aurora:bbf-database-permission-view
Choose a base branch
from
shreyeah38:database_permissions
base: bbf-database-permission-view
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0b68081
Added full support for sys.database_permissions view
shreyaxr3 066eca5
Merge remote-tracking branch 'upstream/BABEL_5_X_DEV' into database_p…
shreyaxr3 7c7b173
Empty-Commit
shreyaxr3 30168b0
Resolved permission error while granting permission on temp tables
shreyaxr3 29e5b2f
Fixed single_db testfiles and created before tesfiles for a few files.
shreyaxr3 06f5391
Fixed Indentation and Formatting
shreyaxr3 1903cb6
Added before input files 1_GRANT_SCHEMA
shreyaxr3 46a5cbe
Fixed db_owner test file where grantor was babelfish internal user
shreyaxr3 cd233ec
Updated metadata inconsistency check to exclude public user role and …
shreyaxr3 9271fea
Fixed the dummy grantor in upgrade script
shreyaxr3 6ccf89f
Fixed testfiles
shreyaxr3 e541ec6
Ignore before files in jdbc_schedule
shreyaxr3 c7ca46e
Handled role does not exist condition for internal BBF object
shreyaxr3 eacc339
Fixed sequence of rows in test file
shreyaxr3 5581341
Replaced the dummy grantor with master_dbo to avoid inconsistency
shreyaxr3 a022076
Created before files for db_owner test file
shreyaxr3 feb9fd6
Added heap tuple is valid check
shreyaxr3 51516a2
Added heap tuple is valid check
shreyaxr3 a4fdd0b
Added condition to return from hook if object type is other than tabl…
shreyaxr3 31463d0
Fixed Indentation and other minor changes
shreyaxr3 12710c8
Passed a common lock inside the functions to avoid race condition
shreyaxr3 cb17e37
db_permissions
shreyaxr3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is permission a primary key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we store "grant" permissions and "grant with options" permissions in 2 different rows. If there's no primary key on permission if would lead to an error when all the parameters are same except the permission.