Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1245 1253 +8
Branches 180 182 +2
=========================================
+ Hits 1245 1253 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
speller26
previously approved these changes
Nov 14, 2025
Contributor
Author
|
thanks @speller26 I've updated the PR |
|
|
||
| def _can_run_as_program_set(self, n_executables: int) -> bool: | ||
| """Whether a list of executables can be run as a program set""" | ||
| return self._supports_program_sets and n_executables < self._max_program_set_executables |
There was a problem hiding this comment.
why is this additional condition necessary now?
Member
There was a problem hiding this comment.
This just allows us to reuse the logic that used to be on line 212
| "A circuit with a ClassicalShadowMP observable must " | ||
| "have that as its only return type." | ||
| ) | ||
| if len(circuits) > 1: |
There was a problem hiding this comment.
This should be first condition in the loop to ensure early return
|
|
||
| @patch.object(AwsDevice, "run") | ||
| def test_batch_execute_program_set_exceeds_max_executables(mock_run): | ||
| @patch.object(AwsDevice, "run_batch") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #313
Description of changes:
This PR fixes support for classical shadow in the Braket PennyLane plugin.
Testing done:
tox
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.