-
Notifications
You must be signed in to change notification settings - Fork 139
feature: Add delay instruction for circuits #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Feature: Add delay and barrier for circuits * doc: Add documentation for delay and barriers * fix: update hash function * rename * fix: whitespace fix * Apply suggestions from code review Co-authored-by: Ryan Shaffer <[email protected]> * Address PR comments * Update test/unit_tests/braket/circuits/test_gates.py * fix: update failing tests * Change duration * change: add unit tests as per PR feedback * Apply suggestions from code review Co-authored-by: Jean-Christophe Jaskula <[email protected]> * Addressing pr feedback * pr feedback: new function * fix: update int as param in delay and barrier * fix: duration accepts FreeParameter expression * fix: fix lint errors * feat: Support SI units, write ascii tests, etc * fix: lint errors * change: Add tests for IR generation of FreeParameter delay. * add tests for ASCII and circuit visualization * change: add tests for DurationGate * lint fix * chore: Add more tests * fix: failing test * revert * Rearrande tests and minor edit * Pr feedback and cleanup --------- Co-authored-by: Ryan Shaffer <[email protected]> Co-authored-by: Jean-Christophe Jaskula <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 162 163 +1
Lines 10450 10526 +76
Branches 1296 1302 +6
=========================================
+ Hits 10450 10526 +76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is there any action in this direction anymore? Not having a barrier makes benchmarking via AWS difficult because any mirror circuits collapse unless verbatim mode is used, e.g. unitaryfoundation/metriq-gym#329 |
|
@nonhermitian we need to get |
@nonhermitian We are picking up this work and hope to have support ready within a few weeks. Will post status updates here as we progress. |
Issue #, if available:
#974
Description of changes:
Starting with the changes from #993 and performing the additional work required to merge to
main.The biggest outstanding items are:
Delay(like the existingBarrier) should inherit fromCompilerDirectiverather thanGate, since it is an instruction that affects the compilation of a program rather than the quantum state. See this comment thread.DurationGateclass and the existingAngledGateclass that should be reduced. See this comment thread.Testing done:
toxMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.