Skip to content

Conversation

@rmshaffer
Copy link
Contributor

@rmshaffer rmshaffer commented Jun 17, 2024

Issue #, if available:
#974

Description of changes:
Starting with the changes from #993 and performing the additional work required to merge to main.

The biggest outstanding items are:

  • Delay (like the existing Barrier) should inherit from CompilerDirective rather than Gate, since it is an instruction that affects the compilation of a program rather than the quantum state. See this comment thread.
  • Significant duplication between the new DurationGate class and the existing AngledGate class that should be reduced. See this comment thread.

Testing done:
tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* Feature: Add delay and barrier for circuits

* doc: Add documentation for delay and barriers

* fix: update hash function

* rename

* fix: whitespace fix

* Apply suggestions from code review

Co-authored-by: Ryan Shaffer <[email protected]>

* Address PR comments

* Update test/unit_tests/braket/circuits/test_gates.py

* fix: update failing tests

* Change duration

* change: add unit tests as per PR feedback

* Apply suggestions from code review

Co-authored-by: Jean-Christophe Jaskula <[email protected]>

* Addressing pr feedback

* pr feedback: new function

* fix: update int as param in delay and barrier

* fix: duration accepts FreeParameter expression

* fix: fix lint errors

* feat: Support SI units, write ascii tests, etc

* fix: lint errors

* change: Add tests for IR generation of FreeParameter delay.

* add tests for ASCII and circuit visualization

* change: add tests for DurationGate

* lint fix

* chore: Add more tests

* fix: failing test

* revert

* Rearrande tests and minor edit

* Pr feedback and cleanup

---------

Co-authored-by: Ryan Shaffer <[email protected]>
Co-authored-by: Jean-Christophe Jaskula <[email protected]>
@codecov
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a76c4e2) to head (af91e62).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1002   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          162       163    +1     
  Lines        10450     10526   +76     
  Branches      1296      1302    +6     
=========================================
+ Hits         10450     10526   +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nonhermitian
Copy link

Is there any action in this direction anymore? Not having a barrier makes benchmarking via AWS difficult because any mirror circuits collapse unless verbatim mode is used, e.g. unitaryfoundation/metriq-gym#329

@rmshaffer
Copy link
Contributor Author

@nonhermitian we need to get barrier added as a supported instruction in the Braket service first, and then we'll merge support for the barrier instruction here. Thank you for the nudge - I'll bring this up with the product team and will follow up when we have a timeline.

@rmshaffer
Copy link
Contributor Author

Is there any action in this direction anymore? Not having a barrier makes benchmarking via AWS difficult because any mirror circuits collapse unless verbatim mode is used, e.g. unitaryfoundation/metriq-gym#329

@nonhermitian We are picking up this work and hope to have support ready within a few weeks. Will post status updates here as we progress.

@nilsquet nilsquet mentioned this pull request Aug 29, 2025
5 tasks
@rmshaffer rmshaffer changed the title feature: Add delay and barrier for circuits feature: Add delay instruction for circuits Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for adding barriers and delays to Circuit

4 participants