Skip to content

Conversation

@AbeCoull
Copy link
Contributor

Issue #, if available:

Description of changes:
aws/sagemaker-python-sdk#4950

SM no longer constrains cloud-pickle

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AbeCoull AbeCoull requested a review from a team as a code owner February 11, 2025 23:26
@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a5f3fe7) to head (b49d3fd).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1063   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          135       135           
  Lines         9087      9087           
  Branches      1046      1046           
=========================================
  Hits          9087      9087           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmshaffer rmshaffer self-requested a review February 12, 2025 19:40
Copy link
Contributor

@rmshaffer rmshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[edit]

Copy link
Contributor

@rmshaffer rmshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding my approval temporarily while we look at any possible downstream impacts to jobs containers.

@rmshaffer
Copy link
Contributor

@AbeCoull I suggest we close this PR for now, unless we have a particular scenario that is blocked? Keeping the version pinned I think reduces our possible test matrix slightly.

@AbeCoull AbeCoull closed this Apr 2, 2025
@AbeCoull AbeCoull deleted the cloud_pickle branch September 10, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants