-
Notifications
You must be signed in to change notification settings - Fork 139
change: Convert direct QuantumTask references to generics
#1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 162 162
Lines 10458 10462 +4
Branches 1296 1296
=========================================
+ Hits 10458 10462 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
nit: I think it would be good to have a description and some information (https://typing.python.org/en/latest/reference/generics.html) for better visibility to others that may look at the PR. ^ I am guilty of not doing the above. I'll be working on making sure the descriptions are properly filled. |
QuantumTask references to generics
Issue #, if available:
Description of changes:
Treat some base classes as generic to make IDE hints more helpful. Without this change, the IDE might complain about methods and properties using the wrong types (like
AwsQuantumTaskinstead ofQuantumTask).Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.