Skip to content

Conversation

@speller26
Copy link
Member

@speller26 speller26 commented Oct 9, 2025

Issue #, if available:

Description of changes:

Treat some base classes as generic to make IDE hints more helpful. Without this change, the IDE might complain about methods and properties using the wrong types (like AwsQuantumTask instead of QuantumTask).

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@speller26 speller26 requested a review from a team as a code owner October 9, 2025 01:57
@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4113a24) to head (503f73d).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          162       162           
  Lines        10458     10462    +4     
  Branches      1296      1296           
=========================================
+ Hits         10458     10462    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AbeCoull
Copy link
Contributor

AbeCoull commented Oct 9, 2025

nit: I think it would be good to have a description and some information (https://typing.python.org/en/latest/reference/generics.html) for better visibility to others that may look at the PR.

^ I am guilty of not doing the above. I'll be working on making sure the descriptions are properly filled.

@speller26 speller26 changed the title change: Start using generics change: Convert direct QuantumTask references to generics Oct 10, 2025
AbeCoull
AbeCoull previously approved these changes Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants