Install golangci-lint from binary #363
Merged
+20
−619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dricross
force-pushed
the
dricross/golangcilint
branch
6 times, most recently
from
056aeea to
60e2d5e
Compare
dricross
force-pushed
the
dricross/golangcilint
branch
from
b50840f to
2ea8ef4
Compare
dricross
commented
Sep 3, 2025
| flock -x 200; \ | ||
| if [ ! -f $@ ]; then \ | ||
| echo "Downloading golangci-lint..."; \ | ||
| curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/HEAD/install.sh | sh -s -- -b $(TOOLS_BIN_DIR) v2.1.1; \ |
There was a problem hiding this comment.
v2.1.1 was chosen as that is the version that was used in the internal/tools/go.mod file previously, so this will keep the linting rules consistent. Trying to use the latest version caused additional linting rules to identify linting issues.
TravisStark
approved these changes
Sep 3, 2025
lisguo
approved these changes
Sep 3, 2025
| @@ -27,225 +26,69 @@ require ( | |||
| ) | |||
|
|
|||
| require ( | |||
| 4d63.com/gocheckcompilerdirectives v1.3.0 // indirect | |||
There was a problem hiding this comment.
all of these dependencies are used to build golangci? wow
agarakan
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
make lintin a fresh environment with no go cache or after runninggo clean -modcache, the process fails because the https://github.com/tdakkota/asciicheck/ repo cannot be found:golangci-lint repo maintainers discovered this issue a couple weeks ago: golangci/golangci-lint#6017. They have a fix but it is not yet released: golangci/golangci-lint#6018.
In the mean time, switching from building
golangci-lintfrom source to installing by downloading the binary directly, as recommended here: https://golangci-lint.run/docs/welcome/install/#local-installation. Hopefully, we can undo this change the next time we synchronize our repo with upstream (golangci-lint should have a fix by then which upstream will consume).Testing
make lintsucceeds after change