-
Notifications
You must be signed in to change notification settings - Fork 38
GH actions Maintenance #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
GH actions Maintenance #1006
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1006 +/- ##
=======================================
Coverage 78.32% 78.32%
=======================================
Files 138 138
Lines 34108 34108
Branches 34108 34108
=======================================
Hits 26716 26716
Misses 5317 5317
Partials 2075 2075 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Errors due There is also a large amount of rustfmt issues since the rustfmt step has been broken due to OS name filter. |
Looks like the |
Very unhappy, lots of stuff that seems to not have been run through rustfmt before. I'll go through and make it happy and drop a |
I'm going to follow up with a different PR to address the rustfmt changes, that way I can squash these changes and have the rustfmt changes stay cleanly separated to be used in |
TIL about |
Issue #, if available: n/a
Description of changes:
This PR updates the actions that we use in our workflows. It also migrates the rust actions that haven't been maintained for a couple years.
Additionally, this PR addresses an issue that resulted in some steps in the workflow not executing due to a bug in how the OS name was being handled.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.