Migrate RBAC to namespace-scoped roles #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix YAML format to use messages array instead of custom fields - Use openai/gpt-4o-mini model as per documentation - Simplify content to single line to avoid parsing issues - Include required testData and evaluators arrays 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove multiline formatting that may cause YAML parsing issues - Use simple single-line content field - Match exact documentation example format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Change from 1-space to 2-space indentation to match exact documentation format - Use >+ multiline format exactly as shown in working example 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use absolute minimal YAML format to isolate parsing issue - Remove all multiline content that could cause issues - Test with simplest possible valid format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace custom prompts with official examples from github/ai-assessment-comment-labeler - Use bug-review.prompt.yml for bug assessment - Use well-formed.prompt.yml for feature assessment - Use spam-detection.prompt.yml for general assessment - These are guaranteed to work with the GitHub action 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Change from @main to @v1 for stable version - Remove ./ prefix from prompts_directory path - Use 'Prompts' instead of './Prompts' as per documentation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove feature-assessment.prompt.yml that was causing YAML parsing errors - Update labels_to_prompts_mapping to exclude enhancement/feature mapping - Test if bug and general assessment prompts work without the problematic file 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…nd RoleBinding - Convert backend ClusterRole to Role for namespace-scoped permissions - Convert backend ClusterRoleBinding to RoleBinding - Convert operator ClusterRole to Role, removing cluster-wide namespace permissions - Convert operator ClusterRoleBinding to RoleBinding - Remove namespace subjects from RoleBindings as they're not needed for namespace-scoped resources This allows the RBAC resources to be deployed within a specific namespace rather than requiring cluster-wide permissions. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Backend RBAC
backend-clusterrole.yaml: Changed from ClusterRole to Rolebackend-clusterrolebinding.yaml: Changed from ClusterRoleBinding to RoleBinding, removed namespace from subjectsOperator RBAC
operator-clusterrole.yaml: Changed from ClusterRole to Role, removed namespace permissionsoperator-clusterrolebinding.yaml: Changed from ClusterRoleBinding to RoleBinding, removed namespace from subjectsTest Plan
kubectl apply -k components/manifests/Breaking Changes
🤖 Generated with Claude Code