Migrate to namespace-scoped RBAC and improve AI assessment workflow #130
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,65 +1,11 @@ | ||
| messages: | ||
| - role: system | ||
| content: >+ | ||
| You are an expert software engineer analyzing bug reports for the vTeam project. vTeam is a comprehensive AI automation platform containing RAT System, Ambient Agentic Runner, and vTeam Tools. Analyze the bug report and provide: 1. Severity assessment (Critical, High, Medium, Low) 2. Component identification (RAT System, Ambient Runner, vTeam Tools, Infrastructure) 3. Priority recommendation based on impact and urgency 4. Suggested labels for proper categorization. The title of the response should be: "### Bug Assessment: Critical" for critical bugs, "### Bug Assessment: Ready for Work" for complete bug reports, or "### Bug Assessment: Needs Details" for incomplete reports. | ||
| - role: user | ||
| content: '{{input}}' | ||
| model: openai/gpt-4o-mini | ||
| modelParameters: | ||
| max_tokens: 100 | ||
| testData: [] | ||
| evaluators: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,91 +1,10 @@ | ||
| messages: | ||
| - role: system | ||
| content: You are a helpful assistant. Analyze the feature request and provide assessment. | ||
| - role: user | ||
| content: '{{input}}' | ||
| model: openai/gpt-4o-mini | ||
| modelParameters: | ||
| max_tokens: 100 | ||
| testData: [] | ||
| evaluators: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,84 +1,11 @@ | ||
| messages: | ||
| - role: system | ||
| content: >+ | ||
| You are an expert technical analyst for the vTeam project helping categorize and assess various types of issues. vTeam is an AI automation platform for engineering workflows including RAT System, Ambient Agentic Runner, and vTeam Tools. For general issues provide appropriate categorization and guidance: Questions (provide classification and suggest resources), Documentation (assess scope and priority), Tasks (evaluate complexity and categorize), Discussions (identify key stakeholders). The title of the response should be: "### Issue Assessment: High Priority" for urgent issues, "### Issue Assessment: Standard" for normal issues, or "### Issue Assessment: Low Priority" for minor issues. | ||
| - role: user | ||
| content: '{{input}}' | ||
| model: openai/gpt-4o-mini | ||
| modelParameters: | ||
| max_tokens: 100 | ||
| testData: [] | ||
| evaluators: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: Role | ||
| metadata: | ||
| name: backend-api | ||
| rules: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,13 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| metadata: | ||
| name: backend-api | ||
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: Role | ||
| name: backend-api | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: backend-api | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,13 @@ | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: RoleBinding | ||
| metadata: | ||
| name: agentic-operator | ||
| roleRef: | ||
|
Comment on lines
1
to
5
There was a problem hiding this comment. [P0] Operator RoleBinding is no longer namespaced The operator RBAC resources were also converted to Useful? React with 👍 / 👎. |
||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: Role | ||
| name: agentic-operator | ||
| subjects: | ||
| - kind: ServiceAccount | ||
| name: agentic-operator | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P0] Namespace omitted after converting backend RBAC to Role/RoleBinding
The backend RBAC was changed from cluster-scoped objects to
Role/RoleBinding, but neither the role manifest nor this binding specifiesmetadata.namespace. When these manifests are applied, Kubernetes will create them in whichever namespace is active (usuallydefault) while thebackend-apiServiceAccount remains hard-coded toambient-code(backend-sa.yaml). As a result, the binding never attaches to the service account and the backend pod loses all permissions to operate onrfeworkflows, leading to immediate authorization failures. Addmetadata.namespace: ambient-code(and ensure the Role lives in the same namespace) so the binding can grant the intended permissions.Useful? React with 👍 / 👎.