Skip to content

Simplify TermInfo #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Simplify TermInfo #102

wants to merge 3 commits into from

Conversation

@encukou
Copy link

@encukou encukou commented Jul 21, 2025

  • Don't parse names, booleans, and numbers. (I hope I left enough code & comments to make it easy to add these if needed.)
  • Don't store the strings as a list; populate the dict directly.
  • Use struct.iter_unpack and string_table.find instead of for loops

@encukou encukou requested a review from ambv as a code owner July 21, 2025 09:57
@encukou
Copy link
Author

encukou commented Jul 21, 2025 •
edited
Loading

Huh, I see I sent this suggestion PR at exactly the time you merged python#136758.
I'll reopen against CPython [edit: see python#136916]. Sorry for the noise.

@encukou encukou closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv Awaiting requested review from ambv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@encukou