Open
Conversation
Collaborator
|
Thanks @wisetara pdflib is a 3rd party library, not created or managed by amCharts. We might merge this in, but it owuld creep back in the next time we grab a new version of pdflib. It's probably best to notify pdfmake crew to make the change: |
Author
|
@martynasma Oh, thank you for letting me know! I was so hopeful to clear us of this thing. Alas. I'll check that out. Thanks so much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up when I fixed the misspellings in my company's codebase--and spotted this one in one of our modules. So, here's this PR.
Oh, and it looks like my text editor auto-fixed some whitespace stuff, too. For reviewer sanity, the only "real" change is here: https://github.com/amcharts/amcharts3/compare/master...wisetara:hierarchy-anarchy?expand=1#diff-5cc8c9454e453ff1ea1ca07b9989318eR29082