Skip to content

Fix hierarchy misspelling#212

Open
wisetara wants to merge 1 commit intoamcharts:masterfrom
wisetara:hierarchy-anarchy
Open

Fix hierarchy misspelling#212
wisetara wants to merge 1 commit intoamcharts:masterfrom
wisetara:hierarchy-anarchy

Conversation

@wisetara
Copy link

This came up when I fixed the misspellings in my company's codebase--and spotted this one in one of our modules. So, here's this PR.

Oh, and it looks like my text editor auto-fixed some whitespace stuff, too. For reviewer sanity, the only "real" change is here: https://github.com/amcharts/amcharts3/compare/master...wisetara:hierarchy-anarchy?expand=1#diff-5cc8c9454e453ff1ea1ca07b9989318eR29082

@martynasma
Copy link
Collaborator

Thanks @wisetara

pdflib is a 3rd party library, not created or managed by amCharts. We might merge this in, but it owuld creep back in the next time we grab a new version of pdflib.

It's probably best to notify pdfmake crew to make the change:
https://github.com/bpampuch/pdfmake

@wisetara
Copy link
Author

@martynasma Oh, thank you for letting me know! I was so hopeful to clear us of this thing. Alas. I'll check that out. Thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants