addressed reviews

Author: alexandraBara

nodescraper/cli/helper.py

@@ -313,33 +313,6 @@ def extract_analyzer_args_from_model(
         return None
 
 
-def extract_collector_args_from_model(
-    plugin_cls: type, data_model: BaseModel, logger: logging.Logger
-) -> Optional[BaseModel]:
-    """Extract collector args from a plugin and a data model.
-
-    Args:
-        plugin_cls (type): The plugin class from registry.
-        data_model (BaseModel): System data model.
-        logger (logging.Logger): logger.
-
-    Returns:
-        Optional[BaseModel]: Instance of collector args model or None if unavailable.
-    """
-    if not hasattr(plugin_cls, "COLLECTOR_ARGS") or not plugin_cls.COLLECTOR_ARGS:
-        logger.warning(
-            "Plugin: %s does not support reference config creation. No collector args defined.",
-            getattr(plugin_cls, "__name__", str(plugin_cls)),
-        )
-        return None
-
-    try:
-        return plugin_cls.COLLECTOR_ARGS.build_from_model(data_model)
-    except NotImplementedError as e:
-        logger.info("%s: %s", plugin_cls.__name__, str(e))
-        return None
-
-
 def generate_reference_config(
     results: list[PluginResult], plugin_reg: PluginRegistry, logger: logging.Logger
 ) -> PluginConfig:
@@ -378,9 +351,6 @@ def generate_reference_config(
         if a_args:
             plugins[obj.source]["analysis_args"] = a_args.model_dump(exclude_none=True)
 
-        c_args = extract_collector_args_from_model(plugin, data_model, logger)
-        if c_args:
-            plugins[obj.source]["collector_args"] = c_args.model_dump(exclude_none=True)
     plugin_config.plugins = plugins
 
     return plugin_config

nodescraper/plugins/inband/process/collector_args.py

@@ -25,20 +25,7 @@
 ###############################################################################
 
 from nodescraper.models import CollectorArgs
-from nodescraper.plugins.inband.process.processdata import ProcessDataModel
 
 
 class ProcessCollectorArgs(CollectorArgs):
     top_n_process: int = 10
-
-    @classmethod
-    def build_from_model(cls, datamodel: ProcessDataModel) -> "ProcessCollectorArgs":
-        """build analyzer args from data model
-
-        Args:
-            datamodel (BiosDataModel): data model for plugin
-
-        Returns:
-            ProcessCollectorArgs: instance of analyzer args class
-        """
-        return cls(top_n_process=datamodel.kfd_process)

test/unit/framework/test_cli_helper.py

@@ -39,7 +39,6 @@
 from nodescraper.cli import cli
 from nodescraper.cli.helper import (
     build_config,
-    extract_collector_args_from_model,
     find_datamodel_and_result,
 )
 from nodescraper.configregistry import ConfigRegistry
@@ -182,59 +181,3 @@ def build_from_model(cls, datamodel):
     assert isinstance(cfg, PluginConfig)
     assert set(cfg.plugins) == {parent}
     assert cfg.plugins[parent]["analysis_args"] == {}
-
-
-def test_no_collector_args_defined(caplog):
-    class NoArgsPlugin:
-        pass
-
-    caplog.set_level(logging.WARNING)
-    res = extract_collector_args_from_model(
-        NoArgsPlugin, DummyDataModel(foo=1), logging.getLogger()
-    )
-    assert res is None
-    assert "does not support reference config creation" in caplog.text
-
-
-def test_collector_args_none(caplog):
-    class NoneArgsPlugin:
-        COLLECTOR_ARGS = None
-
-    caplog.set_level(logging.WARNING)
-    res = extract_collector_args_from_model(
-        NoneArgsPlugin, DummyDataModel(foo=1), logging.getLogger()
-    )
-    assert res is None
-    assert "does not support reference config creation" in caplog.text
-
-
-def test_successful_build_from_model():
-    class MyArgs(BaseModel):
-        a: int
-
-        @classmethod
-        def build_from_model(cls, dm):
-            return cls(a=dm.foo)
-
-    class GoodPlugin:
-        COLLECTOR_ARGS = MyArgs
-
-    dm = DummyDataModel(foo=42)
-    args = extract_collector_args_from_model(GoodPlugin, dm, logging.getLogger())
-    assert isinstance(args, MyArgs)
-    assert args.a == 42
-
-
-def test_build_from_model_not_implemented(caplog):
-    class BadArgs(BaseModel):
-        @classmethod
-        def build_from_model(cls, dm):
-            raise NotImplementedError("not implemented")
-
-    class BadPlugin:
-        COLLECTOR_ARGS = BadArgs
-
-    caplog.set_level(logging.INFO)
-    res = extract_collector_args_from_model(BadPlugin, DummyDataModel(foo=7), logging.getLogger())
-    assert res is None
-    assert "not implemented" in caplog.text