Adding further aie4 shim test support #895

hlaccabu · 2025-12-03T21:22:25Z

No description provided.

Copilot

Pull request overview

This PR extends AIE4 support in the shim test suite by introducing a new debug buffer type (XRT_BO_USE_UC_DEBUG) and broadening test coverage from AIE2-specific to general AIE platform support. The changes enable debug buffer operations to work correctly on AIE4 devices while maintaining backward compatibility with AIE2.

Introduced XRT_BO_USE_UC_DEBUG buffer type for AIE4 debug operations
Extended test coverage from AIE2-only to all AIE platforms for several test cases
Updated buffer creation logic to conditionally use appropriate debug flags based on device type

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
test/shim_test/shim_test.cpp	Conditionally selects debug buffer flags based on AIE4 detection and broadens test filters from AIE2-specific to general AIE support
src/shim/buffer.cpp	Adds mapping for new XRT_BO_USE_UC_DEBUG buffer type to firmware debug buffer type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/shim/buffer.cpp

xdavidz

With this, can we get a pass when run "shim_test" without any index number?

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

test/shim_test/hwctx.h

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

test/shim_test/hwctx.h

hlaccabu · 2026-01-06T23:31:31Z

With this, can we get a pass when run "shim_test" without any index number?

Currently yes, but there are a few more tests that I think I can enable with minimal changes before we merge.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

hlaccabu · 2026-01-07T23:58:39Z

With this, can we get a pass when run "shim_test" without any index number?

Yes to this question on silicon, 38 tests passing.

hlaccabu · 2026-01-08T18:33:27Z

retest this please

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/io_test.cpp

src/shim/umq/hwq.cpp

xdavidz · 2026-01-12T19:09:41Z

With this, can we get a pass when run "shim_test" without any index number?

Currently yes, but there are a few more tests that I think I can enable with minimal changes before we merge.

We should enable all shim_test and just run shim_test without any args.

Are there any shim_test that we decide to run for aie2 only? If not many, we should enable all possible shim_test for aie4.

hlaccabu · 2026-01-12T19:15:56Z

We should enable all shim_test and just run shim_test without any args.

Are there any shim_test that we decide to run for aie2 only? If not many, we should enable all possible shim_test for aie4.

Yes with this PR we can pass 38 shim tests on aie4 by running "./shim_test.elf" without any arguments, the rest are skipped. There are a few tests that will stay as aie2 only, more will be enabled for aie4 after this PR but I did not want to do every change all in one PR that would be too large.

maxzhen · 2026-01-12T20:51:10Z

src/shim/umq/hwq.h

+
+  // Cache for command buffer headers (firmware corrupts them)
+  // Key: BO handle, Value: cached header word
+  std::map<uint32_t, uint32_t> m_cmd_header_cache;


This may not work well. The exec buf can be reused by different applications...

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test/shim_test/shim_test.cpp

Copilot · 2026-01-13T22:31:49Z

test/shim_test/io_test.cpp

-  hwq->wait_command(cbo->get(), 0);
+  auto cmd_hdl = cbo->get();
+  auto cmd_pkt = reinterpret_cast<ert_start_kernel_cmd *>(cbo->map());
+


Blank line with only whitespace. Remove trailing whitespace for consistency with coding standards.

Suggested change

Copilot · 2026-01-13T22:31:49Z

test/shim_test/io.cpp

  auto cbo = m_bo_array[IO_TEST_BO_CMD].tbo.get();
  auto chdl = cbo->get();
+  auto cpkt = reinterpret_cast<ert_start_kernel_cmd *>(cbo->map());
+


Blank line with only whitespace. Remove trailing whitespace for consistency with coding standards.

Suggested change

Copilot · 2026-01-13T22:31:50Z

src/shim/hwq.cpp

+    }
+    return 0;
+  }
+


Blank line with only whitespace. Remove trailing whitespace for consistency with coding standards.

Suggested change

test/shim_test/io.h

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

maxzhen · 2026-01-14T23:59:01Z

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

We successfully confused AI :-)

hlaccabu requested a review from xdavidz December 3, 2025 21:22

hlaccabu added the do-not-merge label Dec 3, 2025

Copilot AI review requested due to automatic review settings December 3, 2025 21:22

Copilot AI reviewed Dec 3, 2025

View reviewed changes

src/shim/buffer.cpp Show resolved Hide resolved

xdavidz reviewed Dec 6, 2025

View reviewed changes

hlaccabu added the multi-repo label Dec 18, 2025

hlaccabu force-pushed the shim branch from 4fa9d38 to db21bc3 Compare December 18, 2025 22:34

hlaccabu force-pushed the shim branch from db21bc3 to e0c0e71 Compare January 6, 2026 00:33

Copilot AI review requested due to automatic review settings January 6, 2026 00:33

Copilot AI reviewed Jan 6, 2026

View reviewed changes

amd deleted a comment from Copilot AI Jan 6, 2026

hlaccabu force-pushed the shim branch from e0c0e71 to d638ff6 Compare January 6, 2026 23:19

Copilot AI review requested due to automatic review settings January 6, 2026 23:25

hlaccabu force-pushed the shim branch from d638ff6 to ee5a16e Compare January 6, 2026 23:25

Copilot AI reviewed Jan 6, 2026

View reviewed changes

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/hwctx.h Show resolved Hide resolved

hlaccabu force-pushed the shim branch from ee5a16e to 60b5c2c Compare January 7, 2026 01:07

hlaccabu removed the multi-repo label Jan 7, 2026

Copilot AI review requested due to automatic review settings January 7, 2026 23:57

hlaccabu force-pushed the shim branch from 60b5c2c to 6af2da8 Compare January 7, 2026 23:57

hlaccabu removed the do-not-merge label Jan 7, 2026

Copilot AI reviewed Jan 7, 2026

View reviewed changes

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

hlaccabu force-pushed the shim branch from 6af2da8 to 183c049 Compare January 8, 2026 00:01

Copilot AI review requested due to automatic review settings January 8, 2026 19:58

hlaccabu force-pushed the shim branch from 183c049 to 92a8188 Compare January 8, 2026 19:58

Copilot AI reviewed Jan 8, 2026

View reviewed changes

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

hlaccabu requested a review from xdavidz January 8, 2026 20:16

hlaccabu force-pushed the shim branch from 92a8188 to 5ab25a9 Compare January 8, 2026 20:49

Copilot AI review requested due to automatic review settings January 9, 2026 03:56

hlaccabu force-pushed the shim branch from 5ab25a9 to fbe0825 Compare January 9, 2026 03:56

Copilot AI reviewed Jan 9, 2026

View reviewed changes

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

test/shim_test/io_test.cpp Outdated Show resolved Hide resolved

src/shim/umq/hwq.cpp Outdated Show resolved Hide resolved

amd deleted a comment from Copilot AI Jan 9, 2026

hlaccabu force-pushed the shim branch from fbe0825 to 480be1b Compare January 9, 2026 04:02

hlaccabu requested a review from maxzhen January 9, 2026 04:03

hlaccabu removed the do-not-merge label Jan 9, 2026

maxzhen reviewed Jan 12, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings January 13, 2026 22:31

hlaccabu force-pushed the shim branch from 480be1b to 20ed205 Compare January 13, 2026 22:31

Copilot AI reviewed Jan 13, 2026

View reviewed changes

hlaccabu requested a review from maxzhen January 13, 2026 22:33

maxzhen requested changes Jan 13, 2026

View reviewed changes

test/shim_test/io.h Outdated Show resolved Hide resolved

hlaccabu force-pushed the shim branch from 20ed205 to 475751d Compare January 14, 2026 00:27

maxzhen requested changes Jan 14, 2026

View reviewed changes

test/shim_test/io.h Outdated Show resolved Hide resolved

hlaccabu added 4 commits January 14, 2026 14:27

Adding further aie4 shim test support

c10964e

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

Remove umq_tests, covered by xrt_test + vadd in shim_test

5136073

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

Creating shim io test support for npu3 full elf flow

01fcb36

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

Add header caching to shim_test code to match xrt::run

549a22f

Signed-off-by: Hayden Laccabue <hlaccabu@amd.com>

Copilot AI review requested due to automatic review settings January 14, 2026 22:45

hlaccabu force-pushed the shim branch from 475751d to 549a22f Compare January 14, 2026 22:45

hlaccabu requested a review from maxzhen January 14, 2026 22:46

maxzhen approved these changes Jan 14, 2026

View reviewed changes

Copilot AI reviewed Jan 14, 2026

View reviewed changes

xdavidz approved these changes Jan 14, 2026

View reviewed changes

maxzhen merged commit cdfed79 into amd:main Jan 14, 2026
1 check passed

hlaccabu deleted the shim branch January 15, 2026 00:17

Adding further aie4 shim test support #895

Adding further aie4 shim test support #895

Uh oh!

Conversation

hlaccabu commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

xdavidz left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hlaccabu commented Jan 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hlaccabu commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hlaccabu commented Jan 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xdavidz commented Jan 12, 2026

Uh oh!

hlaccabu commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxzhen Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

hlaccabu commented Jan 7, 2026 •

edited

Loading

hlaccabu commented Jan 12, 2026 •

edited

Loading