fix(cmake): Align Python3 find strategy with ament_core#40
Open
lbmeng wants to merge 1 commit intoament:rollingfrom
Open
fix(cmake): Align Python3 find strategy with ament_core#40lbmeng wants to merge 1 commit intoament:rollingfrom
lbmeng wants to merge 1 commit intoament:rollingfrom
Conversation
Standardize Python3 interpreter discovery to match ament_cmake_core's established strategy [1], ensuring consistent interpreter selection across the ROS 2 build system. Changes: - Set CMake variable Python3_FIND_STRATEGY to LOCATION - Set CMake variable Python3_FIND_UNVERSIONED_NAMES to FIRST - Bump up the minimum required CMake version to 3.20 This resolves potential inconsistencies where find_package(Python3) might select unintended Python interpreter to build uncrustify. [1] ament_cmake_core/cmake/core/python.cmake Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Contributor
|
It looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize Python3 interpreter discovery to match ament_cmake_core's established strategy [1], ensuring consistent interpreter selection across the ROS 2 build system.
Changes:
This resolves potential inconsistencies where find_package(Python3) might select unintended Python interpreter to build uncrustify.
[1] ament_cmake_core/cmake/core/python.cmake