fix(useFetchye): forceInitialFetch#102
Merged
Matthew-Mallimo merged 9 commits intoamericanexpress:mainfrom Jul 30, 2025
Merged
Conversation
Sam2303
commented
Jul 22, 2025
Matthew-Mallimo
requested changes
Jul 22, 2025
10 tasks
Matthew-Mallimo
approved these changes
Jul 28, 2025
laurenHorton
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the publish of 1.7.0 DyBev found an issue with the
forceInitialFetchand it wasn't working as expected.What I have done is debugged this and adding more conditions around the force fetch, I added comments in the code to explain whats being done and why.
added a condition to the isLoading function to make the isLoading be true on first render when the
forceInitialFetchis passed inadded the new option to the list to be ignored when generating the hash key
Motivation and Context
bugfix
How Has This Been Tested?
unit regression test.
locally packed and ran in a local project
Types of Changes
Checklist:
What is the Impact to Developers Using Fetchye?
actually be able to use the
forceIntialFetchoption and it work as intended