Skip to content

fix(useFetchye): forceInitialFetch#102

Merged
Matthew-Mallimo merged 9 commits intoamericanexpress:mainfrom
Sam2303:fix/useFetchye-forceInitialFetch
Jul 30, 2025
Merged

fix(useFetchye): forceInitialFetch#102
Matthew-Mallimo merged 9 commits intoamericanexpress:mainfrom
Sam2303:fix/useFetchye-forceInitialFetch

Conversation

@Sam2303
Copy link
Copy Markdown
Member

@Sam2303 Sam2303 commented Jul 21, 2025

Description

After the publish of 1.7.0 DyBev found an issue with the forceInitialFetch and it wasn't working as expected.
What I have done is debugged this and adding more conditions around the force fetch, I added comments in the code to explain whats being done and why.
added a condition to the isLoading function to make the isLoading be true on first render when the forceInitialFetch is passed in
added the new option to the list to be ignored when generating the hash key

Motivation and Context

bugfix

How Has This Been Tested?

unit regression test.
locally packed and ran in a local project

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using Fetchye?

actually be able to use the forceIntialFetch option and it work as intended

@Sam2303 Sam2303 marked this pull request as ready for review July 21, 2025 09:24
@Sam2303 Sam2303 requested review from a team as code owners July 21, 2025 09:24
@Sam2303 Sam2303 marked this pull request as draft July 21, 2025 09:28
@Sam2303 Sam2303 marked this pull request as ready for review July 22, 2025 09:17
@Matthew-Mallimo Matthew-Mallimo merged commit 21c00f5 into americanexpress:main Jul 30, 2025
5 of 6 checks passed
@Sam2303 Sam2303 deleted the fix/useFetchye-forceInitialFetch branch July 30, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants