ci(release): use trusted publishers, update lerna deps#112
Merged
Conversation
|
|
* feat(fetchye): expose computeKey * feat(fetchye-one-app): add streamedFetchye thunk * feat(fetchye-one-app): add useStreamedFetchye hook * chore(docs): add streaming docs * chore(jest): update test patterns to target nested directories * chore(nvmrc): match node version from actions * chore(lint): resolve lint errors * feat(fetchye): add throwOnError option for streaming (#111) * feat(fetchye): add throwOnError option for streaming * chore(docs): update docs with throwOnError option * chore(fetchye-one-app): rename streamedFetchye to streamFetchye * refactor(fetchye-one-app): change thunk arg for streamFetchye from promise to function * feat(fetchye-one-app): throw error when response error is present
nicklmart
force-pushed
the
ci/trusted-publisher
branch
from
4624fac to
77a0bf0
Compare
nicklmart
commented
Mar 13, 2026
Comment on lines
+41
to
+44
| if: "startsWith(needs.checkCommit.outputs.commitMsg, 'chore(release):')" | ||
| env: | ||
| NODE_ENV: production | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| run: |- | ||
| echo "//registry.npmjs.org/:_authToken=\${NPM_TOKEN}" >> $HOME/.npmrc 2> /dev/null | ||
| yarn lerna:deploy -- "${{ needs.checkCommit.outputs.commitMsg }}" | ||
| run: yarn lerna:publish |
Contributor
Author
There was a problem hiding this comment.
this should maintain the same behavior as before
nicklmart
commented
Mar 13, 2026
| @@ -0,0 +1 @@ | |||
| registry=https://registry.npmjs.org | |||
Contributor
Author
There was a problem hiding this comment.
yarn 1 honors .npmrc files
code-forger
approved these changes
Mar 16, 2026
laurenHorton
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepare a workflow that can be used with npm's new trusted publisher system.
Motivation and Context
This system uses OIDC and is more secure (and requires less maintenance) than generating a 90 day token.
update to Lerna 9 which supports OIDC: https://lerna.js.org/docs/recipes/oidc-trusted-publishing
How Has This Been Tested?
CI change, all tests green.
Types of Changes
Checklist:
What is the Impact to Developers Using Jest-Image-Snapshot?
This package will be releasable again!