Skip to content

Added optional parameter withing#106

Open
bboyle1234 wants to merge 3 commits intoamis92:masterfrom
bboyle1234:OptionalParameterWithing
Open

Added optional parameter withing#106
bboyle1234 wants to merge 3 commits intoamis92:masterfrom
bboyle1234:OptionalParameterWithing

Conversation

@bboyle1234
Copy link

Made optional struct readonly and prevented defensive struct copying by making "in" method parameters
@amis92
Copy link
Owner

amis92 commented Sep 20, 2019

I'm glad you built this so quickly and easily, working simple code is the best code.

However:

  • Any new Feature should be first hidden behind a new Features flag.
  • Attributes namespace/package isn't the best place for embedding Optional. Also embedding is the last solution I'd like to go with. Let's keep discussing this in A different kind of Wither: With(Optional...) #102.
  • Making the Optional parameters in doesn't really help performance, I think. It's a small struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants